Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#3430): filtering for numerical dimension properties in data explorer #3436

Merged
merged 9 commits into from
Jan 23, 2025
Merged

fix(#3430): filtering for numerical dimension properties in data explorer #3436

merged 9 commits into from
Jan 23, 2025

Conversation

tenthe
Copy link
Contributor

@tenthe tenthe commented Jan 23, 2025

Purpose

The filter in the data explorer had problems handling numerical values. This PR addresses and fixes two main cases:

  1. String property containing numerical values: Numerical filtering failed when numerical values were stored as strings.
  2. Dimension property containing numerical values: Tag values in InfluxDB, which are implicitly handled as strings, caused numerical filtering issues.

Remarks

PR introduces (a) breaking change(s): no

PR introduces (a) deprecation(s): no

@tenthe tenthe linked an issue Jan 23, 2025 that may be closed by this pull request
Filtering for Numerical Dimension Properties in Data Explorer #3430
Closed
@github-actions github-actions bot added java Pull requests that update Java code ui Anything that affects the UI backend Everything that is related to the StreamPipes backend testing Relates to any kind of test (unit test, integration, or E2E test). labels Jan 23, 2025
tenthe added 4 commits January 23, 2025 10:05
@tenthe
fix(#3430): Numerical values are now handled as expected by filters
07be418
@tenthe
Merge remote-tracking branch 'origin/3430-filtering-for-numerical-dim…
accb6e4 
…ension-properties-in-data-explorer' into 3430-filtering-for-numerical-dimension-properties-in-data-explorer

# Conflicts:
#	ui/src/app/data-explorer/components/data-view/data-view-designer-panel/data-settings/filter-selection-panel/filter-selection-panel-row/escape-number-filter.service.ts
@tenthe
fix(#3430): Change directory name to pass windows CI builds
ae86035
@tenthe
fix(#3430): Rename component to meet windows file name length restric…
eb3d4b6 
…tions
@dominikriemer dominikriemer merged commit 1605f6b into dev Jan 23, 2025
22 checks passed
@dominikriemer dominikriemer deleted the 3430-filtering-for-numerical-dimension-properties-in-data-explorer branch January 23, 2025 15:57
@tenthe tenthe restored the 3430-filtering-for-numerical-dimension-properties-in-data-explorer branch January 23, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikriemer dominikriemer dominikriemer approved these changes

Assignees
No one assigned
Labels
backend Everything that is related to the StreamPipes backend java Pull requests that update Java code testing Relates to any kind of test (unit test, integration, or E2E test). ui Anything that affects the UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filtering for Numerical Dimension Properties in Data Explorer
2 participants
@tenthe @dominikriemer