Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Permissions 'can this form get on UserInfoEditView' and 'can this form get on UserInfoEditView' are not associated with Aplha and Gamma by default #32180

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xavier-GitHub76
Copy link
Contributor

Permissions 'can this form get on UserInfoEditView' and 'can this form get on UserInfoEditView' are not associated with Aplha and Gamma by default)

SUMMARY

The permissions are simply unchecked

TESTING INSTRUCTIONS

Inspect the default permissions for each role

…is form get on UserInfoEditView' are not associated with Aplha and Gamma by default
@dosubot dosubot bot added the doc Namespace | Anything related to documentation label Feb 7, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Need a new review? Comment /korbit-review on this PR and I'll review your latest changes.

Korbit Guide: Usage and Customization

Interacting with Korbit

  • You can manually ask Korbit to review your PR using the /korbit-review command in a comment at the root of your PR.
  • You can ask Korbit to generate a new PR description using the /korbit-generate-pr-description command in any comment on your PR.
  • Too many Korbit comments? I can resolve all my comment threads if you use the /korbit-resolve command in any comment on your PR.
  • Chat with Korbit on issues we post by tagging @korbit-ai in your reply.
  • Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.

Customizing Korbit

  • Check out our docs on how you can make Korbit work best for you and your team.
  • Customize Korbit for your organization through the Korbit Console.

Current Korbit Configuration

General Settings
Setting Value
Review Schedule Automatic excluding drafts
Max Issue Count 10
Automatic PR Descriptions
Issue Categories
Category Enabled
Documentation
Logging
Error Handling
Readability
Design
Performance
Security
Functionality

Feedback and Support

Note

Korbit Pro is free for open source projects 🎉

Looking to add Korbit to your team? Get started with a free 2 week trial here

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Feb 7, 2025
@github-actions github-actions bot removed the doc Namespace | Anything related to documentation label Feb 7, 2025
@xavier-GitHub76
Copy link
Contributor Author

I add deletions in documentation for permissions not present in superset 4.1.1 :

  • 7 rows for 'UserOAuthModelView'
  • can function names on Database
  • can schemas access for csv upload on Superset
  • menu access on Upload a CSV
  • menu access on Upload Excel
  • menu access on Upload a Columnar file

For each, I check if an admin can add it on a role

In issue #26056, I mention also permissions like UserRemoteUserModelView / UserDBModelView, could you tell me the difference between ?

@xavier-GitHub76
Copy link
Contributor Author

I found 'UserRemoteUser...' on Superset 4.0.2
QPa6lpdQ8l

or 'UserDB...' also another Superset 4.0.2
6ifpNmwOEe

@xavier-GitHub76
Copy link
Contributor Author

superset/security/manager.py mention :

USER_MODEL_VIEWS = {
"RegisterUserModelView",
"UserDBModelView",
"UserLDAPModelView",
"UserInfoEditView",
"UserOAuthModelView",
"UserOIDModelView",
"UserRemoteUserModelView",
}

"UserDBModelView" is mentionned by 4 files
image

"UserRemoteUserModelView" is only mentionned in superset/security/manager.py
image

If deletion of UserRemoteUserModelView is confirmed others raws are concerned :

  • RegisterUserModelView
  • UserLDAPModelView
  • UserOAuthModelView
  • UserOIDModelView

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant