-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: ODPS data source table preview failed(#32301)-New #32556
Open
zhutong6688
wants to merge
3
commits into
apache:master
Choose a base branch
from
zhutong6688:fix-new-odps-partition-bug-32301
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix: ODPS data source table preview failed(#32301)-New #32556
zhutong6688
wants to merge
3
commits into
apache:master
from
zhutong6688:fix-new-odps-partition-bug-32301
+274
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
Category | Issue | Fix Detected |
---|---|---|
Database-specific logic in generic DAO ▹ view | ||
Tight coupling with concrete engine implementation ▹ view | ||
Redundant Column Metadata Fetch ▹ view | ||
SQL Injection Risk in Partition Query Construction ▹ view | ||
Ineffective Partition Filtering ▹ view | ||
Unnecessary Debug Print Statement ▹ view | ✅ | |
Undocumented Complex Regex Pattern ▹ view | ||
Overly Strict ODPS URI Pattern Matching ▹ view |
Files scanned
File Path | Reviewed |
---|---|
superset/daos/database.py | ✅ |
superset/db_engine_specs/odps.py | ✅ |
superset/sql/parse.py | ✅ |
superset/databases/api.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Need a new review? Comment
/korbit-review
on this PR and I'll review your latest changes.Korbit Guide: Usage and Customization
Interacting with Korbit
- You can manually ask Korbit to review your PR using the
/korbit-review
command in a comment at the root of your PR.- You can ask Korbit to generate a new PR description using the
/korbit-generate-pr-description
command in any comment on your PR.- Too many Korbit comments? I can resolve all my comment threads if you use the
/korbit-resolve
command in any comment on your PR.- On any given comment that Korbit raises on your pull request, you can have a discussion with Korbit by replying to the comment.
- Help train Korbit to improve your reviews by giving a 👍 or 👎 on the comments Korbit posts.
Customizing Korbit
- Check out our docs on how you can make Korbit work best for you and your team.
- Customize Korbit for your organization through the Korbit Console.
Feedback and Support
A print was omitted and deleted during development, and this time it is to delete the print
Just assign this task to me, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
Related to the REST API
data:connect
Namespace | Anything related to db connections / integrations
size/L
sqllab
Namespace | Anything related to the SQL Lab
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
I fixed an error when using sqllab to preview data after configuring the odps data source in superset, and added partition restrictions for previewing SQL
Unlike before, this is a separate collection of the logic of ODPS into a single class(before #32310)
fixes: #32301
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
This is a preview of the odps table data before the repair:

This is a preview of the repaired ODPS table data:



In addition, when using other data sources, there is no problem with testing and it does not affect other data sources
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION