Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hari's GSoC Spell Checking UI: Initial Implementation #500

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

satti-hari-krishna-reddy
Copy link
Contributor

@satti-hari-krishna-reddy satti-hari-krishna-reddy commented Jun 22, 2024

This PR showcases the initial UI implementation for spell-checking with example data.

Next Steps:

  • Refine UI interactions and improvements for enhanced usability based on feedback.

spellCheckerImage

Recording.spell.checking.mp4

@satti-hari-krishna-reddy
Copy link
Contributor Author

@jonorthwash Could you please review my pull request when you have a moment? Thank you!

@satti-hari-krishna-reddy satti-hari-krishna-reddy marked this pull request as ready for review July 26, 2024 11:03
@jonorthwash
Copy link
Member

This is looking really good, just a couple minor things still need to be addressed:

  1. Something that I brought up a couple weeks ago: the menu at the top has really weird spacing.
    Screenshot_2024-08-05_22-11-02

  2. I'm not sure how I feel about center-justified suggestions. What do other spell checkers do?
    Screenshot from 2024-08-05 22-14-58

  3. Are "Spell Checker" (in the menu) and "Check" (on the button) localisable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants