Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operation openapi property support #430

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

operation openapi property support #430

wants to merge 9 commits into from

Conversation

PawelSuwinski
Copy link
Contributor

@PawelSuwinski PawelSuwinski commented Sep 20, 2024 •
edited
Loading

Operation openapiContext property is deprecated and will be removed in Api Platform Core 4.0.
This PR allows transparent migration to openapi property, s/openapiContext:/openapi:/ should be enough in a schema.yaml file.

Resolve #427

@PawelSuwinski
Copy link
Contributor Author

PawelSuwinski commented Sep 20, 2024 •
edited
Loading

UPDATE: no longer relevant, all green

About failed checks:

  1. Does it still have to support legacy php 7.4 version?

Please let me know, to not to put unnecessary work into it making backward compatibility (its mostly about method named arguments). After all it is for Api Platform Core 4.0.

  1. php 8.3 check fail is weird, I have all green on my workstation (?).

@PawelSuwinski PawelSuwinski changed the title operation openapi attribute support operation openapi property support Sep 25, 2024
@PawelSuwinski
Copy link
Contributor Author

PawelSuwinski commented Feb 11, 2025 •
edited
Loading

RFR, WDYT @dunglas ?

@PawelSuwinski
Copy link
Contributor Author

Hi, @soyuka/ @dunglas can we merge this or please can you give some feedback/ review? Checks solved, all green.

dunglas
dunglas requested changes Feb 27, 2025
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the time we took to review.

The approach looks good to me overall, but I left some comments to make the code more readable.

@PawelSuwinski
Copy link
Contributor Author

All fixed, thanks for PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Custom OpenAPI Override via YAML File
2 participants
@PawelSuwinski @dunglas