Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/vue v1/datasearch clear behavior #2284

Merged
merged 9 commits into from
Feb 19, 2024
Merged

Fix/vue v1/datasearch clear behavior #2284

merged 9 commits into from
Feb 19, 2024

Conversation

mohdashraf010897
Copy link
Member

Before submitting a pull request, please make sure the following is done:

  • Describe the proposed changes and how it'll improve the library experience.
  • Please make sure that there are no linting errors in the code.
  • Add a demo video/gif/screenshot to explain how did you test the fix.
  • If it is a global change, try to add any side effects that it could have.
  • Create a PR to add/update the docs (if needed) at here.
  • Create a PR to add/update the storybook (if needed) at here.

Learn more about contributing: Contributing guides

@mohdashraf010897 mohdashraf010897 changed the base branch from next to v3 February 14, 2024 14:42
@github-actions github-actions bot added the vue label Feb 14, 2024
@siddharthlatest siddharthlatest marked this pull request as ready for review February 19, 2024 06:56
@siddharthlatest
Copy link
Member

I've tested this with an example, and lgtm

@siddharthlatest siddharthlatest merged commit e842c31 into v3 Feb 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthlatest siddharthlatest siddharthlatest approved these changes

Assignees
No one assigned
Labels
maps-native native vue web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohdashraf010897 @siddharthlatest