-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tenanting to the golang bindings #11300
base: main
Are you sure you want to change the base?
Conversation
Result of foundationdb-pr-clang-ide on Linux CentOS 7
|
Result of foundationdb-pr-clang on Linux CentOS 7
|
Result of foundationdb-pr-macos-m1 on macOS Ventura 13.x
|
Result of foundationdb-pr-cluster-tests on Linux CentOS 7
|
Result of foundationdb-pr on Linux CentOS 7
|
Result of foundationdb-pr-macos on macOS Ventura 13.x
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM 👍 Thanks for the PR!
assertErrorCodeEqual(t, err, errTenantExists) | ||
} | ||
|
||
func TestOpenNotExistTenant(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is probably causing ctest failure and needs to be commented out. See #11380
return tenants.([]Key), err | ||
} | ||
|
||
func (t Transaction) checkTenantExist(tenantPath Key) (bool, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit:
func (t Transaction) checkTenantExist(tenantPath Key) (bool, error) { | |
func (t Transaction) checkTenantExists(tenantPath Key) (bool, error) { |
@newhook, can you take a look at this PR? AFAIK main is the only branch lacking support for tenants. Thanks. |
Add tenanting to the golang bindings.
Main version of #11299
Code-Reviewer Section
The general pull request guidelines can be found here.
Please check each of the following things and check all boxes before accepting a PR.
For Release-Branches
If this PR is made against a release-branch, please also check the following:
release-branch
ormain
if this is the youngest branch)