Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EventLoop APIs for simpler scheduling of callbacks #2759

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

Add EventLoop APIs for simpler scheduling of callbacks #2759

wants to merge 40 commits into from

Commits on Jun 28, 2024

  1. benchmarks: Add benchmark for MTELG.scheduleTask(in:_:)

    @simonjbeaumont
    simonjbeaumont committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    5f7065f View commit details
    Browse the repository at this point in the history

  2. api: Add NIOTimer, NIOTimerHandler, and EventLoop.setTimer(for:_:)

    @simonjbeaumont
    simonjbeaumont committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    33e82e0 View commit details
    Browse the repository at this point in the history

  3. benchmarks: Add benchmark for MTELG.setTimer(for:_:)

    @simonjbeaumont
    simonjbeaumont committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    b59e31d View commit details
    Browse the repository at this point in the history

  4. internal: Add NIOCustomTimerImplementation conformance to SelectableE… 

    …ventLoop
    @simonjbeaumont
    simonjbeaumont committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    17cf105 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2024

  1. test: Add Linux pre-5.9.2 backport for fulfillment(of:timeout:enforce… 

    …Order:)
    @simonjbeaumont
    simonjbeaumont committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0afb3a2 View commit details
    Browse the repository at this point in the history

  2. test: Increase timer used in shutdown test

    @simonjbeaumont
    simonjbeaumont committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    df3cdb1 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. feedback: Make NIOTimer Sendable

    @simonjbeaumont
    simonjbeaumont committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    b0d3f66 View commit details
    Browse the repository at this point in the history

  2. feedback: Rename timerFired(loop:) to timerFired(eventLoop:)

    @simonjbeaumont
    simonjbeaumont committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    907c087 View commit details
    Browse the repository at this point in the history

  3. feedback(attempted): Store a closure instead of UInt64

    @simonjbeaumont
    simonjbeaumont committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    b3e4903 View commit details
    Browse the repository at this point in the history

  4. feedback(reverted, allocates): Store a closure instead of UInt64 

    This reverts commit 0d9a6f9d6bb4add42e02127daddd01e00d0e6b6d.
    @simonjbeaumont
    simonjbeaumont committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    fb5e835 View commit details
    Browse the repository at this point in the history

  5. feedback(unsure): Replace extra protocol with runtime checks

    @simonjbeaumont
    simonjbeaumont committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    89c57ec View commit details
    Browse the repository at this point in the history

  6. feedback(unsure): Generic timerFired protocol witness

    @simonjbeaumont
    simonjbeaumont committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    59a04de View commit details
    Browse the repository at this point in the history

  7. feedback(unsure): Make setTimer generic over the handler

    @simonjbeaumont
    simonjbeaumont committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    06a4ce7 View commit details
    Browse the repository at this point in the history

  8. feedback: Use labelled parameter for handler

    @simonjbeaumont
    simonjbeaumont committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    950db0c View commit details
    Browse the repository at this point in the history

  9. feedback: Use separate prepositions for TimeAmount and NIODeadline APIs

    @simonjbeaumont
    simonjbeaumont committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    d6ae472 View commit details
    Browse the repository at this point in the history

  10. Remove DocC disambiguation for now until API is decided

    @simonjbeaumont
    simonjbeaumont committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    4439ac6 View commit details
    Browse the repository at this point in the history

  11. feedback: Add documentation to NIOTimerHandler.timerFired protocol re… 

    …quirement
    @simonjbeaumont
    simonjbeaumont committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    abd4b28 View commit details
    Browse the repository at this point in the history

  12. feedback: Change API terms from setTimer to scheduleCallback

    @simonjbeaumont
    simonjbeaumont committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    ceabc7b View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. feedback: Local variable rename: taskId -> taskID

    @simonjbeaumont
    simonjbeaumont committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    80d91f6 View commit details
    Browse the repository at this point in the history

  2. feedback: Reanme NIOScheduledCallbackHandler.onSchedule to handleSche… 

    …duledCallback
    @simonjbeaumont
    simonjbeaumont committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    2ec5543 View commit details
    Browse the repository at this point in the history

  3. feedback: Update protocol requirement documentation comments to use D… 

    …ocC refs
    @simonjbeaumont
    simonjbeaumont committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    5d6ac17 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. feedback: Remove explicit benchmark.stopMeasurement calls

    @simonjbeaumont
    simonjbeaumont committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    bbf8f9f View commit details
    Browse the repository at this point in the history

  2. feedback: Remove TODO following discussion about internal inits

    @simonjbeaumont
    simonjbeaumont committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    21fd1cc View commit details
    Browse the repository at this point in the history

  3. feedback: Make scheduleCallback throwing

    @simonjbeaumont
    simonjbeaumont committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    9bf65f6 View commit details
    Browse the repository at this point in the history

  4. feedback: Add a missing explicit self

    @simonjbeaumont
    simonjbeaumont committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    dbba9e3 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Merge remote-tracking branch 'upstream/main' into sb/timer-api

    @simonjbeaumont
    simonjbeaumont committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    86b8ac3 View commit details
    Browse the repository at this point in the history

  2. Remove broken DocC disambiguatoin and fix test calls

    @simonjbeaumont
    simonjbeaumont committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b16a575 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Update implementation comments in EmbeddedEventLoop and AsyncTestingE… 

    …ventLoop
    @simonjbeaumont
    simonjbeaumont committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    4e71ffb View commit details
    Browse the repository at this point in the history

  2. feedback: Fix preconditionFailure message

    @simonjbeaumont
    simonjbeaumont committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    b909365 View commit details
    Browse the repository at this point in the history

  3. feedback: Move SheduledTask.Kind and kind above other properties

    @simonjbeaumont
    simonjbeaumont committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    5559772 View commit details
    Browse the repository at this point in the history

  4. feedback: Measure .instructions instead of .cpuTotal

    @simonjbeaumont
    simonjbeaumont committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    7f159be View commit details
    Browse the repository at this point in the history

  5. feedback: Remove vestigial references to setTimer in impl comments

    @simonjbeaumont
    simonjbeaumont committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    3ad5647 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Merge remote-tracking branch 'upstream/main' into HEAD

    @simonjbeaumont
    simonjbeaumont committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    bd8fa73 View commit details
    Browse the repository at this point in the history

  2. Add cancellation callback and implicitly cancel on shutdown

    @simonjbeaumont
    simonjbeaumont committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    6af561d View commit details
    Browse the repository at this point in the history

  3. format: Update for new format and lint rules

    @simonjbeaumont
    simonjbeaumont committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    81cc415 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge remote-tracking branch 'upstream/main' into sb/timer-api

    @simonjbeaumont
    simonjbeaumont committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    37ebfde View commit details
    Browse the repository at this point in the history

  2. Remove use of Task.sleep(for:) in tests

    @simonjbeaumont
    simonjbeaumont committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    4467728 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2024

  1. Merge remote-tracking branch 'upstream/main' into sb/timer-api

    @simonjbeaumont
    simonjbeaumont committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    6544461 View commit details
    Browse the repository at this point in the history

  2. Update benchmark to use same config as other benchmarks

    @simonjbeaumont
    simonjbeaumont committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    c48b7aa View commit details
    Browse the repository at this point in the history

  3. Rename onCancelScheduledCallback to didCancelScheduledCallback

    @simonjbeaumont
    simonjbeaumont committed Aug 15, 2024
    Configuration menu
    Copy the full SHA
    151c2c8 View commit details
    Browse the repository at this point in the history