Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Database Deletion Flow #1293

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

ItzNotABug
Copy link
Contributor

What does this PR do?

(Provide a description of what this PR does.)

Test Plan

(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)

Related PRs and Issues

(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)

Have you read the Contributing Guidelines on issues?

(Write your answer here.)

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented Aug 14, 2024

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-10-03 09:55:08 CET

Copy link

vercel bot commented Aug 14, 2024

@ItzNotABug is attempting to deploy a commit to the appwrite Team on Vercel.

A member of the Team first needs to authorize it.

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented Aug 14, 2024

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-10-03 09:55:20 CET

@ItzNotABug
Copy link
Contributor Author

Todo: Add message that the database deletion will also delete its associated backups.

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented Oct 3, 2024

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-10-03 09:55:07 CET

@coolify-appwrite-org
Copy link

coolify-appwrite-org bot commented Oct 3, 2024

The preview deployment is ready. 🟢

Open Preview | Open Build Logs

Last updated at: 2024-10-03 09:55:14 CET

Comment on lines 212 to 215
:global(.no-inner-borders .table) {
box-shadow: unset;
border-radius: unset;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have an option for this, can you check the Table props?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this even makes a difference, I see no changes with or without it, wonder why I added it back then. As per props, I see noMargins and noStyles. Wouldn't use noStyles on this.

Comment on lines +208 to +210
:global(.max-height-dialog dialog) {
max-height: 650px;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the collections list can increase and that would increase the modal height too iirc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants