to sentence case #1589
Merged
to sentence case #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItzNotABug
reviewed
Jan 2, 2025
| @@ -9,7 +9,7 @@ | |||
| </script> | |||
|
|
|||
| <Container> | |||
| <ProxyRulesPage rules={data.rules} type={ResourceType.Api} dependency={Dependencies.DOMAINS}> | |||
| <svelte:fragment slot="heading">Custom Domains</svelte:fragment> | |||
| <ProxyRulesPage rules={data.rules} type={ResourceType.Site} dependency={Dependencies.DOMAINS}> | |||
There was a problem hiding this comment.
how come project api domains to site domains?
There was a problem hiding this comment.
ResourceType.Api doesn't exist anymore:
export enum ResourceType {
Function = 'function',
Site = 'site',
}
There was a problem hiding this comment.
ehh, the sdk model needs to be re-generated I guess. If we use ResourceType.Site, site domains would show up in project settings, which doesn't sound correct to me.
There was a problem hiding this comment.
Ya this sounds odd...I expect there to be 3 types of proxy rules 🧐
There was a problem hiding this comment.
Rolled back after dep upgrade to support it again
ItzNotABug
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix sentence casing for Custom domains
Have you read the Contributing Guidelines on issues?
✅