Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

to sentence case #1589

Merged
merged 3 commits into from
Feb 10, 2025
Merged

to sentence case #1589

merged 3 commits into from
Feb 10, 2025

Conversation

ernstmul
Copy link
Contributor

What does this PR do?

Fix sentence casing for Custom domains

Have you read the Contributing Guidelines on issues?

@@ -9,7 +9,7 @@
</script>

<Container>
<ProxyRulesPage rules={data.rules} type={ResourceType.Api} dependency={Dependencies.DOMAINS}>
<svelte:fragment slot="heading">Custom Domains</svelte:fragment>
<ProxyRulesPage rules={data.rules} type={ResourceType.Site} dependency={Dependencies.DOMAINS}>
Copy link
Member

@ItzNotABug ItzNotABug Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come project api domains to site domains?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ResourceType.Api doesn't exist anymore:

export enum ResourceType {
    Function = 'function',
    Site = 'site',
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ehh, the sdk model needs to be re-generated I guess. If we use ResourceType.Site, site domains would show up in project settings, which doesn't sound correct to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya this sounds odd...I expect there to be 3 types of proxy rules 🧐

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rolled back after dep upgrade to support it again

@ernstmul ernstmul merged commit 008aad1 into feat-pink-v2 Feb 10, 2025
0 of 2 checks passed
@ernstmul ernstmul deleted the fix-sentence-case branch February 27, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants