-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
to sentence case #1589
to sentence case #1589
Conversation
@@ -9,7 +9,7 @@ | |||
</script> | |||
|
|||
<Container> | |||
<ProxyRulesPage rules={data.rules} type={ResourceType.Api} dependency={Dependencies.DOMAINS}> | |||
<svelte:fragment slot="heading">Custom Domains</svelte:fragment> | |||
<ProxyRulesPage rules={data.rules} type={ResourceType.Site} dependency={Dependencies.DOMAINS}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how come project api domains to site domains?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ResourceType.Api
doesn't exist anymore:
export enum ResourceType {
Function = 'function',
Site = 'site',
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ehh, the sdk model needs to be re-generated I guess. If we use ResourceType.Site
, site domains would show up in project settings, which doesn't sound correct to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ya this sounds odd...I expect there to be 3 types of proxy rules 🧐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rolled back after dep upgrade to support it again
What does this PR do?
Fix sentence casing for Custom domains
Have you read the Contributing Guidelines on issues?
✅