Fixing bugs with info, warning, and error count analyzers (#81)

* improving warning analyzer

* improving error count analyzer

* improving info analyzer

* Update __main__.py

src/alogamous/__main__.py

@@ -40,15 +40,14 @@
         [
             # echo_analyzer.EchoAnalyzer(),
             daily_count_analyzer.DailyCountAnalyzer(line_parser),
-            error_counter_analyzer.ErrorCounterAnalyzer(),
+            error_counter_analyzer.ErrorCounterAnalyzer(line_parser),
             flag_duplicate_log_messages.FlagDuplicateLogMessages(),
             line_count_analyzer.LineCountAnalyzer(),
             format_analyzer.FormatAnalyzer(line_parser),
-            warning_analyzer.WarningAnalyzer(),
             loginfo_analyzer.InfoAnalyzer(line_parser),
             stack_trace_analyzer.StackTraceAnalyzer(line_parser),
             # startup_header_analyzer.StartupHeaderAnalyzer(line_parser),
-            warning_analyzer.WarningAnalyzer(),
+            warning_analyzer.WarningAnalyzer(line_parser),
         ],
         reader.read(),
         output_file,

src/alogamous/error_counter_analyzer.py

@@ -1,12 +1,14 @@
-from alogamous import analyzer
+from alogamous import analyzer, log_line_parser
 
 
 class ErrorCounterAnalyzer(analyzer.Analyzer):
-    def __init__(self):
+    def __init__(self, line_parser):
+        self.parser = line_parser
         self.error_number = 0
 
     def read_log_line(self, line):
-        if "ERROR" in line:
+        parsed_line = self.parser.parse(line)
+        if parsed_line["type"] == log_line_parser.LineType.LOG_LINE and parsed_line["level"].lower() == "error":
             self.error_number += 1
 
     def report(self, out_stream):

src/alogamous/loginfo_analyzer.py

@@ -10,7 +10,7 @@ def __init__(self, parser):
     def read_log_line(self, line):
         parsed_line = self.parser.parse(line)
         line_type = parsed_line["type"]
-        if line_type == LineType.LOG_LINE and parsed_line["log_level"].lower() == "info":
+        if line_type == LineType.LOG_LINE and parsed_line["level"].lower() == "info":
             self.infomessage_counter += 1
 
     def report(self, out_stream):

src/alogamous/warning_analyzer.py

@@ -1,14 +1,14 @@
-from alogamous import analyzer
+from alogamous import analyzer, log_line_parser
 
 
 class WarningAnalyzer(analyzer.Analyzer):
-    def __init__(self):
+    def __init__(self, line_parser):
+        self.parser = line_parser
         self.count = 0
 
     def read_log_line(self, line):
-        line_list = line.split(" ")
-        # List should have format [date, timestamp, -, root, -, log message type, -, first word of message...]
-        if line_list[5].lower() == "warning":
+        parsed_line = self.parser.parse(line)
+        if parsed_line["type"] == log_line_parser.LineType.LOG_LINE and parsed_line["level"].lower().startswith("warn"):
             self.count += 1
 
     def report(self, out_stream):

tests/info_counter_test.py

@@ -5,7 +5,7 @@
 
 
 def test_report():
-    infomessage_counter = InfoAnalyzer(LogLineParser(["log_level", "message"], ":", "HEADER"))
+    infomessage_counter = InfoAnalyzer(LogLineParser(["level", "message"], ":", "HEADER"))
     out_stream = io.StringIO()
 
     infomessage_counter.read_log_line("HEADER")
@@ -20,7 +20,7 @@ def test_report():
 
 
 def test_capital_info():
-    infomessage_counter = InfoAnalyzer(LogLineParser(["log_level", "message"], ":", "HEADER"))
+    infomessage_counter = InfoAnalyzer(LogLineParser(["level", "message"], ":", "HEADER"))
     out_stream = io.StringIO()
 
     infomessage_counter.read_log_line("Info: line 1")
@@ -33,7 +33,7 @@ def test_capital_info():
 
 
 def test_report_mixedlines():
-    infomessage_counter = InfoAnalyzer(LogLineParser(["log_level", "message"], ":", "HEADER"))
+    infomessage_counter = InfoAnalyzer(LogLineParser(["level", "message"], ":", "HEADER"))
     out_stream = io.StringIO()
 
     infomessage_counter.read_log_line("info: line 1")
@@ -46,7 +46,7 @@ def test_report_mixedlines():
 
 
 def test_report_without_info_messages():
-    infomessage_counter = InfoAnalyzer(LogLineParser(["log_level", "message"], ":", "HEADER"))
+    infomessage_counter = InfoAnalyzer(LogLineParser(["level", "message"], ":", "HEADER"))
     out_stream = io.StringIO()
 
     infomessage_counter.read_log_line("Warning: line 1")
@@ -59,7 +59,7 @@ def test_report_without_info_messages():
 
 
 def test_no_imput_lines():
-    infomessage_counter = InfoAnalyzer(LogLineParser(["log_level", "message"], ":", "HEADER"))
+    infomessage_counter = InfoAnalyzer(LogLineParser(["level", "message"], ":", "HEADER"))
     out_stream = io.StringIO()
 
     infomessage_counter.report(out_stream)

tests/test_error_counter.py

@@ -1,10 +1,13 @@
 import io
 
-from alogamous import error_counter_analyzer
+from alogamous import error_counter_analyzer, log_line_parser
 
 
 def test_error_counter():
-    counter = error_counter_analyzer.ErrorCounterAnalyzer()
+    parser = log_line_parser.LogLineParser(
+        ["datetime", "source", "level", "message"], " - ", "===================================================="
+    )
+    counter = error_counter_analyzer.ErrorCounterAnalyzer(parser)
     in_stream = io.StringIO(
         """2024-06-20 17:16:03,660 - root - ERROR - Caught exception N/A.
 2024-06-20 17:16:03,660 - root - ERROR - Caught exception N/A. Message: Unclosed connector NoneType: None"""
@@ -17,7 +20,10 @@ def test_error_counter():
 
 
 def test_no_errors():
-    counter = error_counter_analyzer.ErrorCounterAnalyzer()
+    parser = log_line_parser.LogLineParser(
+        ["datetime", "source", "level", "message"], " - ", "===================================================="
+    )
+    counter = error_counter_analyzer.ErrorCounterAnalyzer(parser)
     in_stream = io.StringIO("""2024-06-20 17:17:04,278 - root - INFO - Updating prices
 2024-06-20 17:24:34,091 - root - INFO - Closing client connection.""")
     out_stream = io.StringIO()
@@ -28,7 +34,10 @@ def test_no_errors():
 
 
 def test_no_input_lines():
-    counter = error_counter_analyzer.ErrorCounterAnalyzer()
+    parser = log_line_parser.LogLineParser(
+        ["datetime", "source", "level", "message"], " - ", "===================================================="
+    )
+    counter = error_counter_analyzer.ErrorCounterAnalyzer(parser)
     out_stream = io.StringIO()
     counter.report(out_stream)
     assert out_stream.getvalue().strip() == "Number of error lines: 0"

tests/warning_analyzer_test.py

@@ -1,10 +1,13 @@
 import io
 
-from alogamous import warning_analyzer
+from alogamous import log_line_parser, warning_analyzer
 
 
 def test_warning_count():
-    counter = warning_analyzer.WarningAnalyzer()
+    parser = log_line_parser.LogLineParser(
+        ["datetime", "source", "level", "message"], " - ", "===================================================="
+    )
+    counter = warning_analyzer.WarningAnalyzer(parser)
     in_stream = io.StringIO("""2024-06-20 11:00:18,185 - root - INFO - Kafka reading from start of day 2024-06-20 05:00:00+00:00 on topic internal from kafka.servers:9092
 2024-06-20 11:00:19,328 - root - INFO - Kafka source starting for topic internal at current offset 7924032 end offset 7928950 on servers kafka.servers:9092
 2024-06-20 11:00:22,329 - root - INFO - Kafka topic internal is caught up at offset 7928949