Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reporting with newlines #68

Merged
merged 7 commits into from
Aug 1, 2024
Merged

Reporting with newlines #68

merged 7 commits into from
Aug 1, 2024

Conversation

kitrady
Copy link
Contributor

@kitrady kitrady commented Jul 26, 2024

Closes #59

  • Un-commented analyze_log_stream test
  • analyze_log_stream write newlines to the outstream so reports wouldn't be on same line and would have one blank line to differentiate different reports from eachother
  • Refactored certain analyzers to work well with newline changes

@benrady-aq benrady-aq merged commit 7d2d000 into aquanauts:main Aug 1, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenassour laurenassour laurenassour approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to handle newlines when reporting
3 participants
@kitrady @laurenassour @benrady-aq