Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CIS OpenShift 1.6 Benchmark #1682

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

deebhatia
Copy link

@deebhatia deebhatia commented Sep 18, 2024

This adds support of CIS OpenShift 1.6 Benchmark.

Closes #1457

CIS Benchmark Link

https://workbench.cisecurity.org/benchmarks/16094

CIS Blog mentioning the OpenShift 4.15 release version

https://www.cisecurity.org/insights/blog/cis-benchmarks-july-2024-update#CISRedHatOpenShiftContainerPlatformBenchmarkv1.6.0

Sample Run

Command Used

kube-bench run --json --version ocp-4.16

Report

1_6_results.json

@CLAassistant
Copy link

CLAassistant commented Sep 18, 2024

CLA assistant check
All committers have signed the CLA.

@@ -13,7 +13,7 @@ groups:
type: "manual"
audit: |
#To get a list of users and service accounts with the cluster-admin role
oc get clusterrolebindings -o=customcolumns=NAME:.metadata.name,ROLE:.roleRef.name,SUBJECT:.subjects[*].kind |
oc get clusterrolebindings -o=custom-columns=NAME:.metadata.name,ROLE:.roleRef.name,SUBJECT:.subjects[*].kind |
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a typo in the benchmark. I was comparing both the standards when I identified this. The type is marked as manual, so wasn't caught earlier.

@deebhatia deebhatia force-pushed the cis-openshift-1-6 branch 3 times, most recently from 2873eea to d2041f5 Compare October 14, 2024 17:45
@deebhatia
Copy link
Author

Hi @afdesk @mozillazg,
Can you please take some time and review it. :)

@afdesk
Copy link
Collaborator

afdesk commented Oct 23, 2024

Hi @deebhatia!
thanks for your contribution!
I'll take a look this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants