-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/virtual mem flags parse #3606
base: main
Are you sure you want to change the base?
Feature/virtual mem flags parse #3606
Conversation
An event for accessing the memroy of a process externally (can be the same process) by the mem file of the process in procfs. Co-authored-by: OriGlassman <[email protected]>
@rafaeldtinoco can you tell me your opinion on the last commit? |
Parse vm and gup flags arguments of access_remote_vm.
a6be9ac
to
deb2f1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first commit is being already rebased/reviewed in another PR. The last commit is about the flags parsing and I think we should do the version distincting inside the helper package with a generic function that opts for one or another (or something similar).
The problem with this approach is that you don't know how to user want to use the API. |
You're probably thinking about analyze mode. In that case, we're also missing OSinfo information from the running environment, no ? Thinking about it, like said previously, I believe we should add Either way, I think the decision to parse legacy or not should be delegated to the helper itself. |
We have this update #3875 Please rebase your PR against main to make use of the new workflow setup. |
1. Explain what the PR does
feat(events): parse access_remote_vm args
Parse vm and gup flags arguments of access_remote_vm.
2. Explain how to test it
3. Other comments