Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove ~ prefix when import less file #52

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lianghx-319
Copy link
Contributor

Types of changes

  • New feature
  • Bug fix
  • Documentation change
  • Coding style change
  • Refactoring
  • Performance improvement
  • Test cases
  • Continuous integration
  • Typescript definition change
  • Breaking change

Background and context

When using pnpm link a local package, it's something wrong when resolving .less.
It seem likes webpack cannot handle less files out of the default scope which locate the real path of the symlinks package.

And ~ has deprecated following this link https://github.com/webpack-contrib/less-loader#imports

So I think remove ~ prefix is not a big deal, and it can some how fix the symlinks problem

Solution

How is the change tested?

Changelog

| Changelog(CN) | Changelog(EN) | Related issues |
| 移除引入 .less 文件的 ~ 前缀 | Remove ~ prefix when import less file | -------------- |

Checklist:

  • Provide changelog for relevant changes (e.g. bug fixes and new features) if applicable.
  • Changes are submitted to the appropriate branch (e.g. features should be submitted to feature branch and others should be submitted to master branch)

Other information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant