Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python documentation template #90

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Update python documentation template #90

merged 5 commits into from
Aug 9, 2024

Conversation

rjtokenring
Copy link
Contributor

Reviewer checklist

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in master.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.
  • Mentioned the Analytics team when there are schema changes.

@rjtokenring rjtokenring requested a review from mirkokurt July 30, 2024 09:39
mirkokurt
mirkokurt approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@mirkokurt mirkokurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering: don't we have to add frozendict and typing_extensions here:

clients-iot-api/downstream-templates/python/setup.py

Line 12 in 5a8f8ed

REQUIRES = ["urllib3 >= 1.15", "six >= 1.10", "certifi", "python-dateutil"]

@rjtokenring rjtokenring merged commit efd6a1c into master Aug 9, 2024
2 checks passed
@rjtokenring rjtokenring deleted the update-doc-template branch August 9, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mirkokurt mirkokurt mirkokurt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjtokenring @mirkokurt