Changing BLE hci transport applied to esp idf 4.4 #111
+653
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreagilardoni
force-pushed
the
ble-vhci-over-spi-4.4
branch
from
72efebb to
d1b4c68
Compare
andreagilardoni
changed the base branch from
esp-idf-4.4
to
preferences-idf-4.4
andreagilardoni
force-pushed
the
ble-vhci-over-spi-4.4
branch
from
d1b4c68 to
fe4a3a4
Compare
andreagilardoni
changed the base branch from
preferences-idf-4.4
to
esp-idf-4.4
andreagilardoni
force-pushed
the
ble-vhci-over-spi-4.4
branch
from
fe4a3a4 to
d06f905
Compare
andreagilardoni
changed the base branch from
esp-idf-4.4
to
preferences-idf-4.4
pennam
changed the title
pennam
force-pushed
the
preferences-idf-4.4
branch
from
7396aa2 to
34a9567
Compare
pennam
force-pushed
the
ble-vhci-over-spi-4.4
branch
from
d06f905 to
74df2e3
Compare
pennam
approved these changes
Mar 28, 2025
pennam
reviewed
Mar 28, 2025
| //[2] N args < 1 byte > | ||
| //[3] the number 2 < 1 byte > | ||
| //[4..5] size < 2 byte > | ||
| uint8_t nargs = command[2]; |
There was a problem hiding this comment.
@andreagilardoni I've found a couple of this unused nargs variables in this PR and another in the Preferences PR. Could you please add the check if needed, ore remove the unused variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the same changes performed in #99, but applied to esp idf version 4.4