Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json to incude harmony branch #13

Open
wants to merge 1 commit into
base: harmony
Choose a base branch
from
Open

Update package.json to incude harmony branch #13

wants to merge 1 commit into from

Conversation

BobbyKostadinov
Copy link
Contributor

Request harmony branch for gulp-istanbul for es6 support

@chmontgomery
Copy link
Member

@BobbyKostadinov is this test failure indicative of a problem with gulp-istanbul#harmony?

@BobbyKostadinov
Copy link
Contributor Author

Looking at gulp-istanbul and istanbul itself, they don't seem to keep
harmony branch up to date ... its lacking on both

It would appear that root.js is not included in the test - its not
discovering all there is to test so it doesn't fail as expected in your test

On 23 January 2015 at 15:30, Chris Montgomery [email protected]
wrote:

@BobbyKostadinov https://github.com/BobbyKostadinov is this test
failure indicative of a problem with gulp-istanbul#harmony?


Reply to this email directly or view it on GitHub
#13 (comment)
.

@BobbyKostadinov
Copy link
Contributor Author

Istanbul has separate harmony branches for each release - I'll see if I gulp-istanubl are happy to update ... it gets too long and complicated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants