fix: uri append (#594)

* fix: uri append * fix: uri append
arextest · Dec 12, 2024 · ce9fdcb · ce9fdcb
1 parent 9d6488f
commit ce9fdcb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 17 deletions.
diff --git a/...entation/servlet/arex-httpservlet/src/main/java/io/arex/inst/httpservlet/ServletUtil.java b/...entation/servlet/arex-httpservlet/src/main/java/io/arex/inst/httpservlet/ServletUtil.java
@@ -4,7 +4,6 @@
 import io.arex.agent.bootstrap.util.CollectionUtil;
 import io.arex.agent.bootstrap.util.StringUtil;
 import java.net.URI;
-import java.net.URISyntaxException;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.HashMap;
@@ -20,22 +19,7 @@ private ServletUtil() {
     }
 
     public static String appendUri(String uri, String name, String value) {
-        try {
-            URI oldUri = URI.create(uri);
-            StringBuilder builder = new StringBuilder();
-            String newQuery = oldUri.getQuery();
-            if (oldUri.getQuery() == null) {
-                builder.append(name).append("=").append(value);
-            } else {
-                builder.append(newQuery).append("&").append(name).append("=").append(value);
-            }
-
-            URI newUri = new URI(oldUri.getScheme(), oldUri.getAuthority(),
-                oldUri.getPath(), builder.toString(), oldUri.getFragment());
-            return newUri.toString();
-        } catch (URISyntaxException e) {
-            return uri;
-        }
+        return UriComponentsBuilder.fromUriString(uri).queryParam(name, value).build().toString();
     }
 
     public static String getRequestPath(String uri) {

diff --git a/...tion/servlet/arex-httpservlet/src/test/java/io/arex/inst/httpservlet/ServletUtilTest.java b/...tion/servlet/arex-httpservlet/src/test/java/io/arex/inst/httpservlet/ServletUtilTest.java
@@ -22,6 +22,9 @@ void appendUri() {
 
         assertEquals("http://[email protected]&name=mark#fragment",
             ServletUtil.appendUri("http://[email protected]#fragment", "name", "mark"));
+
+        assertEquals("http://arextest.com?Signature=HJeNHsZ7%2BDMj0JsTK3zd3nzBDQE%3D&name=mark",
+            ServletUtil.appendUri("http://arextest.com?Signature=HJeNHsZ7%2BDMj0JsTK3zd3nzBDQE%3D", "name", "mark"));
     }
 
     @Test