fix: Application controller can run out of disk space on '/dev/shm' (#19201) #19202
+88
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
✅ Preview Environment created on Bunnyshell but will not be auto-deployedSee: Environment Details Available commands (reply to this comment):
|
jgwest
commented
Jul 24, 2024
go.mod
Outdated
| @@ -292,6 +292,7 @@ require ( | |||
| ) | |||
|
|
|||
| replace ( | |||
| github.com/argoproj/gitops-engine => github.com/jgwest/gitops-engine v0.1.3-0.20240717115355-a88f58020142 | |||
There was a problem hiding this comment.
Note to self/reviewer: Ensure this is removed after gitops-engine PR is merged.
jgwest
force-pushed
the
custom-manifest-gen-path-june-2024
branch
2 times, most recently
from
1192e52 to
bcc5c2d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19202 +/- ##
=======================================
Coverage 55.87% 55.87%
=======================================
Files 316 316
Lines 43794 43798 +4
=======================================
+ Hits 24471 24474 +3
Misses 16775 16775
- Partials 2548 2549 +1 ☔ View full report in Codecov by Sentry. |
…rgoproj#19201) Signed-off-by: Jonathan West <[email protected]>
jgwest
force-pushed
the
custom-manifest-gen-path-june-2024
branch
from
bcc5c2d to
66222f1
Compare
…rgoproj#19201) Signed-off-by: Jonathan West <[email protected]>
…rgoproj#19201) Signed-off-by: Jonathan West <[email protected]>
| @@ -175,21 +175,23 @@ func NewLiveStateCache( | |||
| appInformer cache.SharedIndexInformer, | |||
| settingsMgr *settings.SettingsManager, | |||
| kubectl kube.Kubectl, | |||
| manifestGenTmpPath string, | |||
There was a problem hiding this comment.
You don't have to pass this around, use the approach similar to what other options do above, e.g. clusterCacheRetryUseBackoff.
| @@ -75,6 +75,10 @@ data: | |||
| # Enables profile endpoint on the internal metrics port | |||
| controller.profile.enabled: "false" | |||
|
|
|||
| # controller.manifest.generation.path can be used to overwrite the default path (within the application-controller container) used to store the temporary files which are passed to kubectl code via gitops-engine. These temporary files are security sensitive resources, such as generated kubernetes manifests, or cluster credentials. | |||
| # Due to security sensitivity, by default '/dev/shm' is used. However, 'controller.manifest.generation.path' allows this value to be customized, for example, using '/tmp' to overcome the limited disk space of '/dev/shm'. | |||
There was a problem hiding this comment.
Fix extra spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19201
This PR allow the user to customize which path with the application controller container is used to store temporary kubernetes manifests.
See parent issue, and gitops-engine issue/PR, for details.
This PR:
ARGOCD_APPLICATION_CONTROLLER_MANIFEST_GENERATION_PATHDeployment/StatefulSetupdated to optionally read the value fromargocd-cmd-params-cmcontroller.manifest.generation.pathinargocd-cmd-params-cmargocd-cmd-params-cmdocsutil/git/creds.goChecklist: