fix: bump minio-go to newer version #14185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
shuangkun
approved these changes
Feb 12, 2025
Signed-off-by: Vaibhav Kaushik <[email protected]>
|
/retest |
|
/retest |
MasonM
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We deploy Argo Workflows to isolated environments which needs support to pull from corresponding isolated s3 buckets. I have added the corresponding changes to minio-go to include support for the isolated environments & the release v7.0.85 have it available.
Modifications
Bumped minio-go to v7.0.85 in the go.mod
Ran go mod tidy
Verification
I pushed the argoexec image with this change into my local kind cluster and able to pull s3 artifacts.