Merge pull request #1401 from argos-ci/optional-errors

fix(api): mark error.details as optional
argos-ci · Oct 21, 2024 · 067d6f8 · 067d6f8
2 parents 83daf0a + 3b7d9e5
commit 067d6f8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/apps/backend/src/api/schema/util/error.ts b/apps/backend/src/api/schema/util/error.ts
@@ -3,7 +3,7 @@ import { z } from "./zod.js";
 const ErrorSchema = z
   .object({
     error: z.string(),
-    details: z.array(z.object({ message: z.string() })),
+    details: z.array(z.object({ message: z.string() })).optional(),
   })
   .openapi({
     description: "Error response",

diff --git a/apps/backend/src/util/redis/index.ts b/apps/backend/src/util/redis/index.ts
@@ -3,6 +3,7 @@ import { assertNever } from "@argos/util/assertNever";
 import {
   ConnectionTimeoutError,
   createClient,
+  RedisClientType,
   SocketClosedUnexpectedlyError,
 } from "redis";
 
@@ -11,10 +12,10 @@ import logger from "@/logger/index.js";
 
 import { createRedisLock } from "./lock.js";
 
-export const redisClient = createClient({
+export const redisClient: RedisClientType = createClient({
   url: config.get("redis.url"),
   socket: {
-    tls: config.get("redis.url").match(/rediss:/) != null,
+    tls: /rediss:/.test(config.get("redis.url")),
     rejectUnauthorized: false,
   },
 });