Refactor(eos_designs): Refactor eos_designs structured_config code for router_path_selection.py #5002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5002
# Activate the virtual environment
source test-avd-pr-5002/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@refactor/router-path-selection#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,refactor/router-path-selection --force
# Optional: Install AVD examples
cd test-avd-pr-5002
ansible-playbook arista.avd.install_examples |
MaheshGSLAB
reviewed
Feb 11, 2025
| @@ -19,15 +20,13 @@ class RouterPathSelectionMixin(Protocol): | |||
| Class should only be used as Mixin to a AvdStructuredConfig class. | |||
| """ | |||
|
|
|||
| @cached_property | |||
| def router_path_selection(self: AvdStructuredConfigNetworkServicesProtocol) -> dict | None: | |||
| @structured_config_contributor | |||
There was a problem hiding this comment.
Can you update the overlay as well in the same PR
There was a problem hiding this comment.
Updated
Comment on lines
48
to
55
| lb_policy = EosCliConfigGen.RouterPathSelection.LoadBalancePoliciesItem() | ||
| lb_policy._update( | ||
| name=get(match["load_balance_policy"], "name", None), | ||
| lowest_hop_count=get(match["load_balance_policy"], "lowest_hop_count", None), | ||
| jitter=get(match["load_balance_policy"], "jitter", None), | ||
| latency=get(match["load_balance_policy"], "latency", None), | ||
| loss_rate=get(match["load_balance_policy"], "loss_rate", None), | ||
| ) |
There was a problem hiding this comment.
Suggested change
| lb_policy = EosCliConfigGen.RouterPathSelection.LoadBalancePoliciesItem() | |
| lb_policy._update( | |
| name=get(match["load_balance_policy"], "name", None), | |
| lowest_hop_count=get(match["load_balance_policy"], "lowest_hop_count", None), | |
| jitter=get(match["load_balance_policy"], "jitter", None), | |
| latency=get(match["load_balance_policy"], "latency", None), | |
| loss_rate=get(match["load_balance_policy"], "loss_rate", None), | |
| ) | |
| lb_policy = EosCliConfigGen.RouterPathSelection.LoadBalancePoliciesItem( | |
| name=get(match["load_balance_policy"], "name", None), | |
| lowest_hop_count=get(match["load_balance_policy"], "lowest_hop_count", None), | |
| jitter=get(match["load_balance_policy"], "jitter", None), | |
| latency=get(match["load_balance_policy"], "latency", None), | |
| loss_rate=get(match["load_balance_policy"], "loss_rate", None), | |
| ) |
There was a problem hiding this comment.
Also am not sure we should provide the static keys and values. Check if we can update the the match["load_balance_policy"] as object instead of dict from the helper functions
There was a problem hiding this comment.
Applied suggestion in commit.
github-actions
bot
added
state: CI Updated
…r router_path_selection.py
for more information, see https://pre-commit.ci
laxmikantchintakindi
force-pushed
the
refactor/router-path-selection
branch
from
0c85f19 to
751ba2d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Refactor eos_designs structured_config code for router_path_selection.py.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Refactor eos_designs structured_config code for router_path_selection.py.
How to test
Checklist
User Checklist
Repository Checklist