Feat(eos_designs): Add metric bandwidth support for l3_interfaces #5017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5017
# Activate the virtual environment
source test-avd-pr-5017/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ayushmittal-arista/ayush-avd.git@rxtx1#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ayushmittal-arista/ayush-avd.git#/ansible_collections/arista/avd/,rxtx1 --force
# Optional: Install AVD examples
cd test-avd-pr-5017
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: CI Updated
for more information, see https://pre-commit.ci
gmuloc
reviewed
Feb 12, 2025
Comment on lines
68
to
81
| receive_bandwidth: | ||
| type: int | ||
| description: Maximum allowed receive bandwidth (download) in Mbps for this interface. | ||
| min: 1 | ||
| max: 4294967295 | ||
| convert_types: | ||
| - str | ||
| transmit_bandwidth: | ||
| type: int | ||
| description: Maximum allowed transmit bandwidth (upload) in Mbps for this interface. | ||
| min: 1 | ||
| max: 4294967295 | ||
| convert_types: | ||
| - str |
There was a problem hiding this comment.
we may need to limit to physical interfaces only (waiting on engineering answer).
if so we should add a restriction in the code and add a negative unit test
It would be good to add to WAN how-to as well
There was a problem hiding this comment.
added to how-to, please check.
For physical interface check, still wait for the EOS reply.
python-avd/pyavd/_eos_designs/structured_config/overlay/router_path_selection.py
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add receive_bandwidth, transmit_bandwidth fields under l3_interfaces, these will be set under router path selection if these interfaces are configured in the path groups.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_designsProposed changes
Add receive_bandwidth, transmit_bandwidth fields under l3_interfaces,
How to test
molecule
Checklist
User Checklist
Repository Checklist