Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add TWAMP-light data model and router-TE knob #5020

Open
wants to merge 26 commits into
base: devel
Choose a base branch
from

Conversation

emilarista
Copy link
Contributor

Change Summary

Adds data model for TWAMP light configuration under monitor twamp + a sender profile knob under router traffic-engineering.

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

monitor_twamp:
  twamp_light:
    reflector_defaults:
      listen_port: <int>
    sender_defaults:
      destination_port: <int>
      source_port: <int>
    sender_profiles:
      - name: test-profile
        measurement_interval: <int>
        measurement_samples: <int>
        significance:
          value: <int>
          offset: <int>
router_traffic_engineering:
  ...
  twamp_light_sender_profile: <str>

How to test

Tested with molecule and on device.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5020
# Activate the virtual environment
source test-avd-pr-5020/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/emilarista/ansible-avd.git@feat/eos_cli_config_gen/monitor_twamp#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/emilarista/ansible-avd.git#/ansible_collections/arista/avd/,feat/eos_cli_config_gen/monitor_twamp --force
# Optional: Install AVD examples
cd test-avd-pr-5020
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 12, 2025
@emilarista emilarista marked this pull request as ready for review February 12, 2025 14:32
@emilarista emilarista requested review from a team as code owners February 12, 2025 14:32
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Feb 18, 2025
@github-actions github-actions bot removed the state: conflict PR with conflict label Feb 18, 2025
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants