-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add TWAMP-light data model and router-TE knob #5020
Open
emilarista
wants to merge
26
commits into
aristanetworks:devel
Choose a base branch
from
emilarista:feat/eos_cli_config_gen/monitor_twamp
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat(eos_cli_config_gen): Add TWAMP-light data model and router-TE knob #5020
emilarista
wants to merge
26
commits into
aristanetworks:devel
from
emilarista:feat/eos_cli_config_gen/monitor_twamp
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-5020
# Activate the virtual environment
source test-avd-pr-5020/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/emilarista/ansible-avd.git@feat/eos_cli_config_gen/monitor_twamp#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/emilarista/ansible-avd.git#/ansible_collections/arista/avd/,feat/eos_cli_config_gen/monitor_twamp --force
# Optional: Install AVD examples
cd test-avd-pr-5020
ansible-playbook arista.avd.install_examples |
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/router-traffic-engineering.j2
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Feb 12, 2025
...-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_traffic_engineering.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/documentation/router-traffic-engineering.j2
Outdated
Show resolved
Hide resolved
…outer_traffic_engineering.schema.yml Co-authored-by: Claus Holbech <[email protected]>
…/router-traffic-engineering.j2 Co-authored-by: Claus Holbech <[email protected]>
for more information, see https://pre-commit.ci
MaheshGSLAB
reviewed
Feb 14, 2025
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/monitor_twamp.schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/monitor_twamp.schema.yml
Outdated
Show resolved
Hide resolved
...llections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/monitor-twamp.yml
Show resolved
Hide resolved
...llections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/host1/monitor-twamp.yml
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
requested changes
Feb 18, 2025
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/monitor_twamp.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/monitor_twamp.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/monitor_twamp.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/monitor_twamp.schema.yml
Show resolved
Hide resolved
…onitor_twamp.schema.yml Co-authored-by: Claus Holbech <[email protected]>
…onitor_twamp.schema.yml Co-authored-by: Claus Holbech <[email protected]>
…onitor_twamp.schema.yml Co-authored-by: Claus Holbech <[email protected]>
for more information, see https://pre-commit.ci
ClausHolbechArista
approved these changes
Feb 21, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Adds data model for TWAMP light configuration under monitor twamp + a sender profile knob under router traffic-engineering.
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Tested with molecule and on device.
Checklist
Repository Checklist