use correct Fq and Fr for tom-256 and remove overridden method

Signed-off-by: lovesh <[email protected]>
arkworks-rs · Jan 29, 2025 · f90020f · f90020f
1 parent bd72258
commit f90020f
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 19 deletions.
diff --git a/curves/tom_256/Cargo.toml b/curves/tom_256/Cargo.toml
@@ -2,7 +2,7 @@
 name = "ark-tom256"
 version.workspace = true
 authors.workspace = true
-description = "The secp256k1 curve"
+description = "The Tom-256 curve"
 homepage.workspace = true
 repository.workspace = true
 documentation = "https://docs.rs/ark-tom256/"

diff --git a/curves/tom_256/src/curves/mod.rs b/curves/tom_256/src/curves/mod.rs
@@ -2,7 +2,7 @@ use ark_ec::{
     models::CurveConfig,
     short_weierstrass::{self as sw, SWCurveConfig},
 };
-use ark_ff::{Field, MontFp, Zero};
+use ark_ff::{Field, MontFp};
 
 use crate::{fq::Fq, fr::Fr};
 
@@ -29,24 +29,20 @@ impl CurveConfig for Config {
 
 impl SWCurveConfig for Config {
     /// COEFF_A = 115792089210356248762697446949407573530594504085698471288169790229257723883796
-    const COEFF_A: Fq = MontFp!("115792089210356248762697446949407573530594504085698471288169790229257723883796");
+    const COEFF_A: Fq =
+        MontFp!("115792089210356248762697446949407573530594504085698471288169790229257723883796");
 
     /// COEFF_B = 81531206846337786915455327229510804132577517753388365729879493166393691077718
-    const COEFF_B: Fq = MontFp!("81531206846337786915455327229510804132577517753388365729879493166393691077718");
+    const COEFF_B: Fq =
+        MontFp!("81531206846337786915455327229510804132577517753388365729879493166393691077718");
 
     /// GENERATOR = (G_GENERATOR_X, G_GENERATOR_Y)
     const GENERATOR: Affine = Affine::new_unchecked(G_GENERATOR_X, G_GENERATOR_Y);
-
-    #[inline(always)]
-    fn mul_by_a(_: Self::BaseField) -> Self::BaseField {
-        Self::BaseField::zero()
-    }
 }
 
 /// G_GENERATOR_X =
 /// 3
-pub const G_GENERATOR_X: Fq =
-    MontFp!("3");
+pub const G_GENERATOR_X: Fq = MontFp!("3");
 
 /// G_GENERATOR_Y =
 /// 40902200210088653215032584946694356296222563095503428277299570638400093548589

diff --git a/curves/tom_256/src/fields/fq.rs b/curves/tom_256/src/fields/fq.rs
@@ -1,9 +1,9 @@
 use ark_ff::fields::{Fp256, MontBackend, MontConfig};
 
 #[derive(MontConfig)]
-#[modulus = "115792089210356248762697446949407573530086143415290314195533631308867097853951"]
-#[generator = "3"]
-#[small_subgroup_base = "3"]
-#[small_subgroup_power = "1"]
+#[modulus = "115792089210356248762697446949407573530594504085698471288169790229257723883799"]
+#[generator = "6"]
+// #[small_subgroup_base = "3"]
+// #[small_subgroup_power = "1"]
 pub struct FqConfig;
 pub type Fq = Fp256<MontBackend<FqConfig, 4>>;
diff --git a/curves/tom_256/src/fields/fr.rs b/curves/tom_256/src/fields/fr.rs
@@ -1,9 +1,9 @@
 use ark_ff::fields::{Fp256, MontBackend, MontConfig};
 
 #[derive(MontConfig)]
-#[modulus = "115792089210356248762697446949407573530594504085698471288169790229257723883799"]
-#[generator = "7"]
-#[small_subgroup_base = "3"]
-#[small_subgroup_power = "1"]
+#[modulus = "115792089210356248762697446949407573530086143415290314195533631308867097853951"]
+#[generator = "6"]
+// #[small_subgroup_base = "3"]
+// #[small_subgroup_power = "1"]
 pub struct FrConfig;
 pub type Fr = Fp256<MontBackend<FrConfig, 4>>;