Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DensePolynomial: add to_coefficients_vec #917

Closed
wants to merge 1 commit into from
Closed

DensePolynomial: add to_coefficients_vec #917

wants to merge 1 commit into from

Conversation

zhiqiangxu
Copy link
Contributor

@zhiqiangxu zhiqiangxu commented Jan 8, 2025 •
edited
Loading

This PR adds a to_coefficients_vec to DensePolynomial, so that external users can convert vec to DensePolynomial with from_coefficients_vec, and after computations finally converts DensePolynomial back to vec with to_coefficients_vec without copy.

@zhiqiangxu zhiqiangxu requested review from a team as code owners January 8, 2025 03:36
@zhiqiangxu zhiqiangxu requested review from z-tech, Pratyush and tyshko-rostyslav and removed request for a team January 8, 2025 03:36
z-tech
z-tech reviewed Mar 3, 2025
View reviewed changes
Copy link
Contributor

@z-tech z-tech left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these different? Line 112: https://github.com/arkworks-rs/algebra/pull/917/files#diff-f1b52becf4d86f0547472f506301b63a979f1b3e3f35288acd62533adfb6864cR112

@Pratyush
Copy link
Member

Pratyush commented Mar 5, 2025

You can always do poly.coeffs to extract the coefficients with a move. Can you point to a codebase where you use this?

@zhiqiangxu
Copy link
Contributor Author

You can always do poly.coeffs to extract the coefficients with a move. Can you point to a codebase where you use this?

Ah correct, I didn't notice it's public. Closing.

@zhiqiangxu zhiqiangxu closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@z-tech z-tech z-tech left review comments

@Pratyush Pratyush Awaiting requested review from Pratyush Pratyush is a code owner automatically assigned from arkworks-rs/maintainers

@tyshko-rostyslav tyshko-rostyslav Awaiting requested review from tyshko-rostyslav tyshko-rostyslav is a code owner automatically assigned from arkworks-rs/maintainers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqiangxu @Pratyush @z-tech