Fix: must_use on traits has no effect and causes CI to fail #946
+0
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z-tech
requested review from
Pratyush,
mmagician and
weikengchen
and removed request for
a team
Pratyush
reviewed
Feb 28, 2025
| @@ -570,7 +570,6 @@ impl<P: QuadExtConfig> From<bool> for QuadExtField<P> { | |||
| impl<P: QuadExtConfig> Neg for QuadExtField<P> { | |||
| type Output = Self; | |||
| #[inline] | |||
| #[must_use] | |||
There was a problem hiding this comment.
Why do we need to remove it from here as well?
There was a problem hiding this comment.
Running this from the CI on 1.87.0-nightly, RUSTFLAGS="-D warnings" cargo check --all-features --examples --workspace --benches gives:
error: #[must_use] has no effect when applied to a provided trait method
--> ff/src/fields/models/quadratic_extension.rs:573:5
|
573 | #[must_use]
| ^^^^^^^^^^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: must_use on traits has no effect and causes CI to fail
As of Rust 1.87.0-nightly, #[must_use] on provided trait methods triggers a warning, which becomes an error under cargo check with -D warnings, breaking CI.
Since it had no effect to begin with I think it's safe to remove and we need to do this to resolve CI werrors.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer