Implement efficient addition formula for affine points #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR implements the efficient addition formula for affine points in short Weierstrass curves. Previously, when adding two affine points, they were first converted to projective coordinates and then the general addition formula was used. This implementation directly computes the sum of two affine points using the specialized formula for z=1, which is more efficient. The implementation includes: 1. Direct addition formula for affine points 2. Special case handling for infinity and point doubling 3. A new double() method for affine points This resolves the TODO comment in the affine.rs file.
VolodymyrBg
requested review from
z-tech,
Pratyush and
mmagician
and removed request for
a team
|
This uses an inversion, and will be much slower. |
|
@Pratyush |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the efficient addition formula for affine points in short Weierstrass curves.
Previously, when adding two affine points, they were first converted to projective coordinates and then the general addition formula was used. This implementation directly computes the sum of two affine points using the specialized formula for z=1, which is more efficient.
The implementation includes:
This resolves the TODO comment in the affine.rs file.