Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Summary of Changes #162

Closed
wants to merge 2 commits into from
Closed

Summary of Changes #162

wants to merge 2 commits into from

Conversation

donatik27
Copy link

@donatik27 donatik27 commented Dec 4, 2024

This pull request corrects the spelling of "Pederson" to "Pedersen" in the documentation comments. The correct spelling is important as it refers to the Pedersen commitment scheme, named after the Danish cryptographer Torben Pedersen.

Changes Made:

  1. File: poly-commit/src/hyrax/data_structures.rs

    • Line 10: Changed Pederson to Pedersen in the comment:
      /// `UniversalParams` amounts to a Pedersen commitment key of sufficient length
      
    • Line 95: Changed Pederson to Pedersen in the comment:
      /// element in the Pedersen commitment key for a different commitment
      
  2. File: poly-commit/src/hyrax/mod.rs

    • Line 28: Changed committment to commitment in the comment:
      /// Hyrax polynomial commitment scheme:
      

Reason for Changes

  • Correct Spelling: The term "Pedersen" is the correct spelling for the commitment scheme, ensuring accuracy and clarity in the documentation.
  • Typographical Correction: Corrected "committment" to "commitment" to maintain consistency and professionalism in the codebase.

@donatik27 donatik27 requested a review from a team as a code owner December 4, 2024 18:16
@donatik27 donatik27 requested review from z-tech, Pratyush and tyshko-rostyslav and removed request for a team December 4, 2024 18:16
@Pratyush
Copy link
Member

Pratyush commented Dec 4, 2024

Please don't make GPT-driven PRs

@Pratyush Pratyush closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants