-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for c4 spi #7263
base: main
Are you sure you want to change the base?
Fix for c4 spi #7263
Conversation
Directionally I agree with this, we shouldn't have any "spidev" or other special devices trees in any kernel that supports overlays. If we can get a second check by anyone with a C4 I think this is a good move. |
One question not related to that... in case being approved, would it make sense to transfer this patch to 6.11 kernel to make sure it doesn't get lost? |
My fault. I can't spew out overlays, as the syntax remains a mystery to me.
Indeed. I think exactly the same change can be done to 6.11/edge. |
No. Your effort! I took the stuff you did and fiddled into an overlay. I don't understand that syntax (I assume only few people really do), and I had some teachings from other gurus here so I could barely do it. |
add patch for 6.11 into this PR, please. |
Could you please advise how to do this? This is my first PR ever... |
Description
This pull requests adds a device tree overlay for the Odroid C4 enabling hardware SPI on pins 19, 21, 23 and 24 on the GPIO header. It doesn't require any other changes, except one additional line in the Makefile.
Besides, it can replace the old device tree meson-sm1-odroid-c4-spidev.dtb (which activates wrong pins and doesn't work due to this) while offering more flexibility.
How Has This Been Tested?
The SPI communication has been successfully tested with a LogicPort analyzer and some custom made FPGA board (SPI readout of a Mamamatsu silicon spectrometer).
Checklist: