Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make calcualtion request aync #95

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make calcualtion request aync #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/app/api/credmanager/createCalculationRequest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import { ContributionRequest } from "@prisma/client";
import prisma from "db";

export async function createContributionRequest(
teamId: string,
gitHubToken: string,
email: string,
): Promise<ContributionRequest> {
const contributionRequest = await prisma.contributionRequest.create({
data: {
team_id: teamId,
access_token: gitHubToken,
email: email,
},
});
return contributionRequest;
}
23 changes: 10 additions & 13 deletions src/app/api/credmanager/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { NextRequest, NextResponse } from "next/server";
import { options } from "../auth/[...nextauth]/options";
import { getServerSession } from "next-auth";
import { EventName, createEvent } from "../event/createEvent";
import { createContributionRequest } from "./createCalculationRequest";

export interface UserCredDto {
totalCred: number;
Expand All @@ -10,27 +11,23 @@ export interface UserCredDto {
}

export async function GET(req: NextRequest) {
// try {
const teamId = req.nextUrl.searchParams.get("team_id");
const session = await getServerSession(options);
if (teamId && session?.userId != null) {
const CRED_MANAGER_ROUTE = process.env.CRED_MANAGER_ROUTE;
const calculatedUserCredDtos = await fetch(
`${CRED_MANAGER_ROUTE}/cred/team/${teamId}/${session?.accessToken}/${session?.user?.email}`,
{
method: "GET",
},
);
createEvent(session?.userId, EventName.REQUEST_CALCULATION, {
teamId: teamId,
});

const contributionRequest = await createContributionRequest(
teamId,
session.accessToken!,
session!.user!.email!,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's check that the session.user exist with an if condition, using "!" on the backend could cause several issues

);

return NextResponse.json({
success: true,
Comment on lines 27 to 28
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we double check if no api query handler is using the userCredDtos[] field on the api response?

userCredDtos: calculatedUserCredDtos.json(),
});
} else {
return NextResponse.json({ success: false });
}
// } catch (error) {
// console.error(error);
return NextResponse.json({ success: false, userCredDtos: [] });
// }
}