Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncation of bytes/bytes_read/bytes_written stats #156

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aroben
Copy link

@aroben aroben commented Oct 2, 2014

These stats are stored in a uint64_t but we were truncating them to 32 bits.

These stats are stored in a uint64_t but we were truncating them to 32
bits.
@@ -87,15 +87,15 @@ static memcached_return set_data(memcached_stat_st *memc_stat, char *key, char *
}
else if (!strcmp("bytes_read", key))
{
memc_stat->bytes_read= (uint32_t) strtoll(value, (char **)NULL, 10);
memc_stat->bytes_read= (uint64_t) strtoll(value, (char **)NULL, 10);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we be using strtoull so we aren't casting away the sign?

It seems like there might be an edge case if you had a value greater than LLONG_MAX but less than ULLONG_MAX. The manual says the value would be truncated to LLONG_MAX, giving us 63 bits instead of 64.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newer versions of libmemcached do use strtoull, so I suspect you're correct. However what I changed the code to here matches the other 64-bit stats (like cmd_get a few lines below the end of this diff). I wanted to make as small a change as possible to fix the immediate issue, which is truncating to 32 bits. It seems unlikely that we would end up with a value greater than 2^63 (8 exabytes) here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, if a more complete fix is desired I'd be happy to switch to strtoull everywhere.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, after I saw the diff I looked at the whole file and saw strtoll being used everywhere for unsigned left hand values and realized why you went this route.

@arthurnn
Copy link
Owner

arthurnn commented Feb 6, 2016

hey @aroben , thanks for the PR.
We just embed the memcached C client in the gem. So, is this changed in the C client? If so, I can bump it here. Otherwise we might need to send a patch there instead.

@aroben
Copy link
Author

aroben commented Feb 7, 2016

So, is this changed in the C client?

Yeah, as mentioned above, newer versions of the C client have already fixed this bug.

@arthurnn
Copy link
Owner

arthurnn commented Feb 8, 2016

@aroben , I am looking into update the client here, as it is SUPER old.. but before I have all that done, I need to get CI back to green, and after I have that I will merge this for us..
thanks a lot

@dylanahsmith
Copy link
Collaborator

The embedded libmemcached has been upgraded to 1.0.18 on master now, which is the newest release, so I think this can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants