fix: workaround ansible inconsistent var handling

[mhitza]

Context: if a variable is defined within a set_fact module call, and the variable value is used within the new varibles defined via set_fact. If the variable defined already has a value, within the set_fact variables the existing value will be used instead of the newly assigned value. Encounted with Ansible version 2.16.3

Reproduction example:

- ansible.builtin.set_fact:
    status: "no a json"

- ansible.builtin.shell: >
     echo "{ \"Self\": { \"Online\": true }, \"Version\": 1.0 }"
  changed_when: false
  register: tailscale_status

- vars:
    status: "{{ tailscale_status.stdout | from_json }}" # <- does not take place
  ansible.builtin.set_fact:
    tailscale_is_online: "{{ status.Self.Online }}"
    tailscale_version: "{{ status.Version }}"

---

How I encountered the issue. In a project where the devsec.hardening collection -> os_hardeding role is used alongside this role, and that roles is included before this role. It defines it's own status variable which triggers a failure case in this role on the changed lines.

In some sense it looks like an unintentional behaviour that it works to use vars alongside set_fact as it's not listed as part of the attributes it supports https://docs.ansible.com/ansible/latest/collections/ansible/builtin/set_fact_module.html

The same behaviour is relied upon within the handlers, which I've also changed as it was triggering the error.

Upstream issue reported in Ansible ansible/ansible#82698

[flowerysong]

A better choice would be to use a less generic name for this temporary variable, rather than exacerbating the situation by making this role's status variable clobber any one that's set elsewhere.

[artis3n]

Thank you for this PR!

[mhitza]

@artis3n any planned new release for the role that includes this fix?

[artis3n]

Yes, sorry I am meaning to release it under other structural changes to this role and I've needed to set aside time to get those other things done.

[artis3n]

Published a patch release tonight to get this and some other changes out while the larger changes are still in progress.