-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Improve decommission process_2 #435
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can't reproduce the failing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Often, when I run the role with
state: absent
, the next role run withstate: present
will fail with different errors. For example, like described in the bug#429
After talking to Tailscale support, that issue might happen if
/var/lib/tailscale/
still contains the previous machine identity (state, auth key, id, etc).We have to remove this folder during decommission.
Fortunately, Ubuntu package has that task inside the
tailscale.postrm
, (if the user runeapt purge tailscale
):So, this is the best way to handle tailscale state removal -
purge: true,
because this will always be aligned with the package maintainers config.I am not sure about other distros, though.
Probably, we need a task like this in each distro subtree:
@artis3n ,
As we discussed here
#430 (comment)
I removed variable from the code.
Please let me know how do you prefer to handle this or if you need any help?
P.S. This is part of
#430