Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix templating of tailscale_args_string if tailscale_tags is an empty list #506

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

UnholyRope
Copy link

tailscale_tags_string templated to None, which is not a valid argument.

It would template to something like "--login-server=https://ts.example.com None --timeout=120s", with None being an invalid argument causing the following error:

fatal: [host]: FAILED! => {"ansible_job_id": "j1.1", "changed": true, "cmd": ["tailscale", "up", "--login-server=https://ts.example.com", "None", "--timeout=120s", "--authkey=1234"], "delta": "0:00:00.004653", "end": "2024-09-19 12:59:36.991005", "finished": 1, "msg": "non-zero return code", "rc": 1, "results_file": "/root/.ansible_async/j1.1", "start": "2024-09-19 12:59:36.986352", "started": 1, "stderr": "too many non-flag arguments: [\"None\" \"--timeout=120s\" \"--auth-key=1234\"]", "stderr_lines": ["too many non-flag arguments: [\"None\" \"--timeout=120s\" \"--auth-key=1234\"]"], "stdout": "", "stdout_lines": []}

This seems to be an issue since v4.4.0.

… list

tailscale_tags_string templated to `None`, which is not a valid argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant