Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(DIA-942): write tests for auth2 infrastructure #11211

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

iskounen
Copy link
Contributor

@iskounen iskounen commented Nov 27, 2024

This PR resolves DIA-942

Description

This PR adds tests for the infrastructure of auth2, which includes AuthContext, AuthScreen and the useAuthNavigation hook.

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Added tests for auth2 infrastructure

Need help with something? Have a look at our docs, or get in touch with us.

@iskounen iskounen self-assigned this Nov 27, 2024
@iskounen iskounen marked this pull request as draft November 27, 2024 18:59
@iskounen iskounen marked this pull request as ready for review November 27, 2024 20:57
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Dev changes (Added tests for auth2 infrastructure - iskounen)

Generated by 🚫 dangerJS against 434eb43

Copy link
Member

@damassi damassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great ⭐

And that's a wrap!

@iskounen iskounen merged commit cc9ef21 into main Nov 27, 2024
8 checks passed
@iskounen iskounen deleted the iskounen/chore/test-auth2-infra branch November 27, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants