Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prefer canonical artist bio on artwork screen #11265

Merged

Conversation

anandaroop
Copy link
Member

@anandaroop anandaroop commented Dec 9, 2024

This PR resolves PBRW-127 and PBRW-249

Description

On web/mWeb when we display an artist's bio within the context of an artwork page, we prefer the canonical version of the bio.

But it looks like we never made the equivalent change in the app, so this addresses that.

Before After (iOS) After (Android) Web (for comparison)
before after android web

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • Prefer canonical artist bio on artwork screen

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@anandaroop anandaroop marked this pull request as ready for review December 9, 2024 23:18
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Dec 9, 2024

This PR contains the following changes:

  • Cross-platform user-facing changes (Prefer canonical artist bio on artwork screen - anandaroop)

Generated by 🚫 dangerJS against 7fd51c8

gkartalis
gkartalis previously approved these changes Dec 10, 2024
src/app/Scenes/Artwork/Components/AboutArtist.tsx Outdated Show resolved Hide resolved
@anandaroop anandaroop force-pushed the anandaroop/PBRW-127-PBRW-249-prefer-canonical-artist-bio branch from 92f9bae to 7fd51c8 Compare December 10, 2024 14:26
Copy link
Member

@jonallured jonallured left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🎉

@anandaroop anandaroop merged commit 396ab8c into main Dec 10, 2024
7 checks passed
@anandaroop anandaroop deleted the anandaroop/PBRW-127-PBRW-249-prefer-canonical-artist-bio branch December 10, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants