Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(DIA-1015): infinite discovery swiping behavior #11292

Merged
merged 12 commits into from
Jan 8, 2025
Merged

feat(DIA-1015): infinite discovery swiping behavior #11292

merged 12 commits into from
Jan 8, 2025

Conversation

iskounen
Copy link
Contributor

@iskounen iskounen commented Dec 17, 2024 •
edited
Loading

This PR continues work on Infinite Discovery. It:

  • Adds the ability to hide the × and ♡ buttons in the FancySwiper
  • Displays the first 100 artworks in the Curator's Pick collection
  • Fixes several glitches involving the header
  • Replaces the easy peasy context (for now) with simpler hooks
  • Adds tests that mock the swiping behavior
  • Renames components
  • Reorders props alphabetically
Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-01-08.at.06.47.37.mp4

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Improvements to Infinite Discovery

Need help with something? Have a look at our docs, or get in touch with us.

@iskounen iskounen self-assigned this Dec 17, 2024
@iskounen iskounen marked this pull request as draft December 17, 2024 10:07
@iskounen iskounen force-pushed the iskounen/feat/infinite-discovery-swipe branch 2 times, most recently from 7852372 to 1d1327d Compare December 20, 2024 17:56
@iskounen iskounen force-pushed the iskounen/feat/infinite-discovery-swipe branch from 1d1327d to 6ff6439 Compare January 8, 2025 11:51
@iskounen iskounen requested a review from MounirDhahri January 8, 2025 11:56
@iskounen iskounen marked this pull request as ready for review January 8, 2025 12:03
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Jan 8, 2025 •
edited
Loading

This PR contains the following changes:

  • Dev changes (Improvements to Infinite Discovery - iskounen)

Generated by 🚫 dangerJS against 84dc1df

@iskounen iskounen force-pushed the iskounen/feat/infinite-discovery-swipe branch from 6ff6439 to 413f64f Compare January 8, 2025 14:57
MounirDhahri
MounirDhahri reviewed Jan 8, 2025
View reviewed changes
iskounen
iskounen commented Jan 8, 2025
View reviewed changes
src/app/Scenes/InfiniteDiscovery/__tests__/InfiniteDiscovery.tests.tsx
}),
}

const swipeLeft = () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MounirDhahri I was able to simulate the swipe action with these 3 events. It's a lot of code for a little swipe, but I feel better using a synthetic event than a mocked component.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome 💯

@iskounen iskounen added the Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green label Jan 8, 2025
@artsy-peril artsy-peril bot merged commit c9077c1 into main Jan 8, 2025
7 checks passed
@artsy-peril artsy-peril bot deleted the iskounen/feat/infinite-discovery-swipe branch January 8, 2025 18:50
MounirDhahri
MounirDhahri reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Adam for addressing my comments. LGTM

src/app/Scenes/InfiniteDiscovery/__tests__/InfiniteDiscovery.tests.tsx
}),
}

const swipeLeft = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MounirDhahri MounirDhahri MounirDhahri left review comments

Assignees

@iskounen iskounen

Labels
Squash On Green A label to indicate that Peril should squash-merge this PR when all statuses are green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iskounen @ArtsyOpenSource @MounirDhahri