fix: restore image fallbacks #11307
Merged
fix: restore image fallbacks #11307
+117
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MounirDhahri
approved these changes
Dec 18, 2024
|
Thank you 🙏 |
MounirDhahri
pushed a commit
that referenced
this pull request
Dec 18, 2024
* add fallback image and use in ThreeUpImageLayout * add fallback image in places we added url checks * few missed images * fix imports * add test for fallback image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
Fixes error causing auctions not to render as well as a few other images I missed in migration.
This restores some behavior we had with the old opaqueImageView, that is if a null or undefined url is passed render a gray box as a fallback. It looks like this:
Screenshot
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.