feat(DIA-1062): refetch infinite discovery #11395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskounen
changed the title
iskounen
force-pushed
the
iskounen/feat/infinite-discovery-pagination
branch
from
900ef37 to
0959c32
Compare
damassi
reviewed
Jan 16, 2025
iskounen
commented
Jan 16, 2025
|
|
||
| return <InfiniteDiscovery artworks={initialData} /> | ||
| }, | ||
| LoadingFallback: SpinnerFallback, |
There was a problem hiding this comment.
This LoadingFallback is displayed in two situations: when the component first loads, and when the component refetches its data. However, I want two different things to happen in those situations:
- When the component first loads, I want to show a skeleton loader
- When the component refetches its data, I don't want the component to redraw (because that should happen in the background while the user is viewing the second-to-last artwork.
iskounen
added
the
Squash On Green
iskounen
commented
Jan 16, 2025
| refetch( | ||
| { excludeArtworkIds: artworks.map((artwork) => artwork.internalID) }, | ||
| { | ||
| fetchPolicy: "network-only", |
There was a problem hiding this comment.
I think this is the correct fetch policy because these we are fetching artworks that should not have been "discovered" before.
artsy-peril
bot
deleted the
iskounen/feat/infinite-discovery-pagination
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates Infinite Discovery to use the
discoverArtworkquery (with refetch) to create an infinite scroll.Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-01-16.at.15.02.11.mp4
Some outstanding issues to be followed-up on:
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.