Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve push notification permission handling and tracking #11812

Merged
merged 3 commits into from
Apr 2, 2025

Conversation

gkartalis
Copy link
Member

@gkartalis gkartalis commented Mar 31, 2025

This PR resolves PHIRE-1670

Description

We are firing analytics events related to push permissions on every app launch, this PR changes this to only fire on the first time that user sees the dialog.

Platform Before After
iOS
b4.mov
after.mov
iOS
b4.mp4
after.mp4

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • improve push notification permission handling and tracking

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Mar 31, 2025

This PR contains the following changes:

  • Dev changes (improve push notification permission handling and tracking - gkartalis)

Generated by 🚫 dangerJS against a822dd0

@gkartalis
Copy link
Member Author

cc @louislecluse

Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this addition! I think at some point it would be great to migrate this logic to RN

I think It would make maintaining it easier over the long term

@gkartalis gkartalis merged commit ef586cd into main Apr 2, 2025
7 checks passed
@gkartalis gkartalis deleted the gkartalis/PHIRE-1670 branch April 2, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants