Viewing room list cards #3457
Viewing room list cards #3457
Conversation
Co-authored-by: Matt Dole <[email protected]>
|
huh @pvinis I checked out the branch and tried opening a VR from the sim - still took me to the screen within the app and not the web view https://share.getcloudapp.com/YEupoEdE no clue what's up there. maybe ask the MX team tomorrow? |
|
It was that I didn't have the lab option enabled on my sim 🤦. Interesting how everything else worked so far with that being off. Anyway, this should be ready to be merged now 👍. |
There was a problem hiding this comment.
Awesome! Great job @pvinis. Only questions I have are:
- Should we be using Styled Components throughout?
- What's your vision for tests? Is there anything we should test with these individual components, or should we wait until we're making use of them?
|
I actually forgot about this pr 😅. hm I didn't think of using styled. I guess we can. For tests, since we are moving these to palette I think we could add some tests here later but I don't have a specific plan. I'm ok with either merging and doing they changes in palette, or closing and doing everything directly in palette. |
|
Ah yeah, and I forgot we're moving all of this to Palette haha. I'm going to reassign to you and let you make that call, both are totally reasonable to me and I'm not sure what your plan is for Palette so I don't want to slow you down! Let me know if I can help though |
# Conflicts: # data/schema.graphql # package.json # src/lib/AppRegistry.tsx
…ist can calculate correctly
|
Sorry for the many changes after upgrading this Pr from a draft to a regular one. This should be ready now. |
|
@mdole - can this be merged? |
|
@damassi ah sorry I keep getting distracted mid-review. I'll have a couple notes up in the next ~20min |
|
With everything solved, I'll go ahead and mark this #mergeongreen. |
|
@pvinis for important new dependencies we normally talk about them in an RFC before adding them to eigen. I think relay-hooks definitely fits the bill. Do you mind submitting an RFC retroactively? |
|
Oh sure. I thought it's small enough, as it's basically some hooks for relay that we already have. |
Keep in mind:
Using cards from palette.
Removed an unused file still left from storybook.
Added
RelayEnvironmentProviderto be able to use relay-hooks.Now with pagination.
iPad layout supported.
Pair with @mdole on making some tests.
Update to palette after the pending one.