WIP: Fix image alt text when it has double quotes #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1765,6 +1765,11 @@ def class_string node | |||
| def role_valid_class? role | |||
| role.is_a? String | |||
| end | |||
|
|
|||
| def encode_alt_text node, val, to_attr = false | |||
There was a problem hiding this comment.
I suggest naming this in a more generic way, like encode_attribute_value from HTML5 converter. We also do not need to escape anything besides " because others are already escaped.
There was a problem hiding this comment.
Thanks for the suggestions! Will try to implement them and add unit tests. Mine was a quick WIP hack copying code from asciidoctor.
There was a problem hiding this comment.
Wait, we even already have a function for that: xml_sanitize does exactly what is needed.
slonopotamus
added a commit
to slonopotamus/asciidoctor-epub3
that referenced
this pull request
Jan 7, 2024
slonopotamus
added a commit
to slonopotamus/asciidoctor-epub3
that referenced
this pull request
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.