Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Honour roles for items in olists and ulists #469

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

someth2say
Copy link
Contributor

Usually list items do not have extra roles (AsciiDoc does not allow roles in list items as per today), but they can be added via processors.
This PR honour the roles, and inject them into the generated list items.

@slonopotamus slonopotamus merged commit 2070c4c into asciidoctor:main Apr 18, 2024
11 checks passed
@mojavelinux
Copy link
Member

I don't think style should be supported. It's not relevant for list items. The built-in HTML converter only passes though the role in this case, so we should be consistent with that.

@someth2say
Copy link
Contributor Author

I don't think style should be supported. It's not relevant for list items. The built-in HTML converter only passes though the role in this case, so we should be consistent with that.

To be true, I don´t ever grasp where the style comes from nor what are its semantics. I just copied classes are assigned to ol/ul nodes.
Consistency is positive, though.

@mojavelinux
Copy link
Member

mojavelinux commented Apr 19, 2024

Again, style is not relevant for list items. The style is something that is specific to blocks, and even then only very special blocks like lists (for the marker or numeration style) or the source block (to differentiate it from a listing block). It should not be included in this case as it is not consistent.

@slonopotamus
Copy link
Contributor

Okay, let's drop style, but keep role

slonopotamus added a commit that referenced this pull request May 12, 2024
@slonopotamus slonopotamus added this to the next milestone May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants