Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sidebar deep link #480

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

meonkeys
Copy link
Contributor

Adds id attribute support to sidebar.

Fixes "Fragment identifier is not defined." error when trying to deep-link a sidebar. For example:

ERROR(RSC-012): foo.epub/EPUB/_chapter.xhtml(LINE,COLUMN): Fragment identifier is not defined.

Fixes "Fragment identifier is not defined." error when trying to deep-link a sidebar.
For example:

```
ERROR(RSC-012): foo.epub/EPUB/_chapter.xhtml(LINE,COLUMN): Fragment identifier is not defined.
```
@slonopotamus slonopotamus merged commit 05e9def into asciidoctor:main May 23, 2024
11 checks passed
@slonopotamus
Copy link
Contributor

Thanks!

@meonkeys meonkeys deleted the fix-sidebar-deep-link branch May 23, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants