Code Optimization

ashishrawat2911 · Aug 7, 2022 · e2fc8c6 · e2fc8c6
1 parent 715840b
commit e2fc8c6
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 14 deletions.
diff --git a/...movie_entity_to_movie_details_mapper.dart → lib/data/mapper/movie_domain_mapper.dart b/...movie_entity_to_movie_details_mapper.dart → lib/data/mapper/movie_domain_mapper.dart
@@ -1,17 +1,16 @@
-import 'package:injectable/injectable.dart';
 import 'package:popular_movies/data/source/local/database/model/movie_entity.dart';
 import 'package:popular_movies/data/source/remote/model/video_response.dart';
 import 'package:popular_movies/domain/model/movie.dart';
 import 'package:popular_movies/domain/model/movie_details.dart';
 import 'package:popular_movies/domain/model/video.dart';
 import 'package:smartstruct/smartstruct.dart';
-
+import 'package:injectable/injectable.dart';
 import '../source/remote/model/movie_response_model.dart';
 
-part 'movie_entity_to_movie_details_mapper.mapper.g.dart';
+part 'movie_domain_mapper.mapper.g.dart';
 
 @Mapper(useInjection: true)
-abstract class MovieMapper {
+abstract class MovieDomainMapper {
   MovieDetails movieEntityToMovieDetails(MovieEntity movieEntity);
 
   Movie movieEntityToMovie(MovieEntity movieEntity);

diff --git a/...ity_to_movie_details_mapper.mapper.g.dart → .../mapper/movie_domain_mapper.mapper.g.dart b/...ity_to_movie_details_mapper.mapper.g.dart → .../mapper/movie_domain_mapper.mapper.g.dart
diff --git a/lib/data/source/movie_data_store_factory.dart b/lib/data/source/movie_data_store_factory.dart
@@ -1,7 +1,7 @@
 import 'package:injectable/injectable.dart';
 import 'package:popular_movies/core/extention/list_extentions.dart';
 import 'package:popular_movies/core/services/connectivity_service.dart';
-import 'package:popular_movies/data/mapper/movie_entity_to_movie_details_mapper.dart';
+import 'package:popular_movies/data/mapper/movie_domain_mapper.dart';
 import 'package:popular_movies/data/source/movie_local_data_source.dart';
 import 'package:popular_movies/data/source/movie_remote_data_source.dart';
 import 'package:popular_movies/domain/model/movie_details.dart';
@@ -11,7 +11,7 @@ import '../../domain/model/movie.dart';
 
 @singleton
 class MovieDataStoreFactory {
-  final MovieMapper _movieMapper;
+  final MovieDomainMapper _movieMapper;
   final MovieLocalDataSource _movieLocalDataSource;
   final MovieRemoteDataSource _movieRemoteDataSource;
   final ConnectivityService connectivityService;

diff --git a/lib/di/di.config.dart b/lib/di/di.config.dart
diff --git a/lib/presentation/features/movie_detail/view_model/movie_details_view_model.dart b/lib/presentation/features/movie_detail/view_model/movie_details_view_model.dart
@@ -18,7 +18,6 @@ class MoviesDetailsViewModel extends Cubit<MovieDetailState> {
   }
 
   void getMovieDetails(int id) async {
-    getVideos(id);
     final result = await _getMovieDetailUseCase.execute(id);
     result.fold((l) {
       emit(state.copyWith(movieDetailResultState: MovieDetailResultState.error(l)));