Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update node to version 18 #24

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ckcherry23
Copy link

@ckcherry23 ckcherry23 commented Dec 15, 2023

Fixes #22

I'm updating to node v18 by using ncu and fixing any functionality that breaks.
Others feel free to contribute or create a new PR entirely as I'm only working intermittently.

Currently working on migrating docs.

@ashutosh1919
Copy link
Owner

@ckcherry23 Thanks for contribution. Please fix CI errors. Also, Can you please remove package-lock file from commit. It will help for review.

@ckcherry23
Copy link
Author

The CI errors are due to the build failing as per this update from Netlify: https://answers.netlify.com/t/please-read-end-of-support-for-xenial-build-image-everything-you-need-to-know/68239. We need to upgrade to the latest build image in the Netlify UI for the docs site because the Xenial build image is not supported anymore.

However, I haven't been able to successfully migrate the gatsby smooth-docs to node v18 yet due to dependency conflicts. Will update here when I find a solution.

@ashutosh1919 ashutosh1919 marked this pull request as ready for review December 27, 2023 04:48
@ashutosh1919
Copy link
Owner

@ckcherry23 I tried building it after updating the image to Focal image. But it still fails. Most probably due to version mismatch. Can you please have a look? https://app.netlify.com/sites/awesome-loaders/deploys/658bad511eb6072229c8b3ba

@ckcherry23
Copy link
Author

I was able to find a solution for the docs deployment but it isn't ideal.

  1. Disable npm install by setting a new environment variable NPM_FLAGS as --dry-run.
  2. Change the build command to the following:
npm i --ignore-scripts && npm rebuild --verbose sharp && npm run build

This command is to ignore the old python2 script that doesn't work on python3 during the package installation and then fix issues with sharp before the build.

Following these steps made the deployment possible but there are minor styling issues on the homepage: https://deploy-preview-1--deft-kheer-283f6c.netlify.app/.

Here is the deployment log: https://app.netlify.com/sites/deft-kheer-283f6c/deploys/658ecb579d7cd1b2858d5303.

@ashutosh1919
Copy link
Owner

@ckcherry23 I think the styling issues might be due to incompatible version of npm dependencies responsible for styling.

@ckcherry23
Copy link
Author

@ckcherry23 I think the styling issues might be due to incompatible version of npm dependencies responsible for styling.

Would you prefer switching to other libraries or frameworks for these? The issues may not be possible to fix if we continue using smooth-doc. I think since it is just for documentation, some minor styling issues should not affect much, but I can look at other solutions if you think it is necessary.

@ashutosh1919
Copy link
Owner

@ckcherry23 We don't necessarily need to stick with smooth-doc. You can use whatever deps you want to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install due to dependency conflicts
2 participants