-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update node to version 18 #24
base: main
Are you sure you want to change the base?
Conversation
@ckcherry23 Thanks for contribution. Please fix CI errors. Also, Can you please remove package-lock file from commit. It will help for review. |
The CI errors are due to the build failing as per this update from Netlify: https://answers.netlify.com/t/please-read-end-of-support-for-xenial-build-image-everything-you-need-to-know/68239. We need to upgrade to the latest build image in the Netlify UI for the docs site because the Xenial build image is not supported anymore. However, I haven't been able to successfully migrate the gatsby smooth-docs to node v18 yet due to dependency conflicts. Will update here when I find a solution. |
@ckcherry23 I tried building it after updating the image to Focal image. But it still fails. Most probably due to version mismatch. Can you please have a look? https://app.netlify.com/sites/awesome-loaders/deploys/658bad511eb6072229c8b3ba |
I was able to find a solution for the docs deployment but it isn't ideal.
npm i --ignore-scripts && npm rebuild --verbose sharp && npm run build This command is to ignore the old python2 script that doesn't work on python3 during the package installation and then fix issues with sharp before the build. Following these steps made the deployment possible but there are minor styling issues on the homepage: https://deploy-preview-1--deft-kheer-283f6c.netlify.app/. Here is the deployment log: https://app.netlify.com/sites/deft-kheer-283f6c/deploys/658ecb579d7cd1b2858d5303. |
@ckcherry23 I think the styling issues might be due to incompatible version of npm dependencies responsible for styling. |
Would you prefer switching to other libraries or frameworks for these? The issues may not be possible to fix if we continue using |
@ckcherry23 We don't necessarily need to stick with |
Fixes #22
I'm updating to node v18 by using
ncu
and fixing any functionality that breaks.Others feel free to contribute or create a new PR entirely as I'm only working intermittently.
Currently working on migrating docs.