[red-knot] Resolve Options to Settings
#16000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
force-pushed
the
micha/settings
branch
from
f84f5cf to
ec24cfa
Compare
MichaReiser
added
cli
MichaReiser
force-pushed
the
micha/settings
branch
from
ec24cfa to
9020e41
Compare
MichaReiser
requested review from
carljm,
AlexWaygood and
sharkdp
as code owners
dhruvmanila
reviewed
Feb 7, 2025
| /// | ||
| /// Settings that are part of [`ProgramSettings`] are not included here. | ||
| #[derive(Clone, Debug, Eq, PartialEq)] | ||
| pub struct Settings { |
There was a problem hiding this comment.
I believe this will help in converting the mdtest config options into the final resolved settings for the project?
There was a problem hiding this comment.
Probably not because the mdtest framework doesn't depend on red_knot_project, unless we decide to change that.
dhruvmanila
approved these changes
Feb 7, 2025
MichaReiser
force-pushed
the
micha/settings
branch
from
9020e41 to
9a3f1b0
Compare
MichaReiser
force-pushed
the
micha/settings
branch
from
af800c6 to
71e4b89
Compare
|
dcreager
added a commit
that referenced
this pull request
Feb 10, 2025
* main: (991 commits) [red-knot] Resolve `Options` to `Settings` (#16000) Bump version to 0.9.6 (#16074) Revert tailwindcss v4 update (#16075) Improve migration document (#16072) Fix reference definition labels for backtick-quoted shortcut links (#16035) RUF009 should behave similar to B008 and ignore attributes with immutable types (#16048) [`pylint`] Also report when the object isn't a literal (`PLE1310`) (#15985) Update Rust crate rustc-hash to v2.1.1 (#16060) Root exclusions in the server to project root (#16043) Directly include `Settings` struct for the server (#16042) Update Rust crate clap to v4.5.28 (#16059) Update Rust crate strum_macros to 0.27.0 (#16065) Update NPM Development dependencies (#16067) Update Rust crate uuid to v1.13.1 (#16066) Update Rust crate strum to 0.27.0 (#16064) Update pre-commit dependencies (#16063) Update dependency ruff to v0.9.5 (#16062) Update Rust crate toml to v0.8.20 (#16061) [`flake8-builtins`] Make strict module name comparison optional (`A005`) (#15951) [`ruff`] Indented form feeds (`RUF054`) (#16049) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR generalize the idea that we may want to emit diagnostics for
invalid or incompatible configuration values similar to how we already
do it for
rules.This PR introduces a new
Settingsstruct that is similar toOptionsbut, unlikeOptions, are fields have their default values filled in and they use a representation optimized for reads.The diagnostics created during loading the
Settingsare stored on theProjectso that we can emit them when callingcheck.The motivation for this work is that it simplifies adding new settings. That's also why I went ahead and added the
terminal.error-on-warningsetting to demonstrate how new settings are added.Test Plan
Existing tests, new CLI test.