[red-knot] Document 'public type of undeclared symbols' behavior #16096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
requested review from
carljm,
MichaReiser and
AlexWaygood
as code owners
sharkdp
force-pushed
the
david/public-type-undeclared
branch
from
57b4851 to
68e979b
Compare
sharkdp
force-pushed
the
david/public-type-undeclared
branch
from
68e979b to
3136623
Compare
AlexWaygood
reviewed
Feb 11, 2025
crates/red_knot_python_semantic/resources/mdtest/doc/public_type_undeclared_symbols.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/doc/public_type_undeclared_symbols.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/doc/public_type_undeclared_symbols.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/doc/public_type_undeclared_symbols.md
Outdated
Show resolved
Hide resolved
AlexWaygood
approved these changes
Feb 11, 2025
crates/red_knot_python_semantic/resources/mdtest/doc/public_type_undeclared_symbols.md
Outdated
Show resolved
Hide resolved
carljm
approved these changes
Feb 11, 2025
crates/red_knot_python_semantic/resources/mdtest/doc/public_type_undeclared_symbols.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/doc/public_type_undeclared_symbols.md
Outdated
Show resolved
Hide resolved
crates/red_knot_python_semantic/resources/mdtest/doc/public_type_undeclared_symbols.md
Outdated
Show resolved
Hide resolved
carljm
reviewed
Feb 11, 2025
crates/red_knot_python_semantic/resources/mdtest/doc/public_type_undeclared_symbols.md
Outdated
Show resolved
Hide resolved
carljm
approved these changes
Feb 11, 2025
crates/red_knot_python_semantic/resources/mdtest/doc/public_type_undeclared_symbols.md
Outdated
Show resolved
Hide resolved
dhruvmanila
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After I was asked twice within the same day, I thought it would be a good idea to write some user facing documentation that explains our reasoning behind inferring
Unknown | T_inferredfor public uses of undeclared symbols. This is a major deviation from the behavior of other type checkers and it seems like a good practice to defend our choice like this. Please let me know if I missed something or if you see a chance to explain this more clearly.Rendered version